Re: [PATCH V2 07/16] drm/vc4: Get the rid of DRM_ERROR()

2024-07-30 Thread Maíra Canal
On 7/28/24 08:41, Stefan Wahren wrote: DRM_ERROR() has been deprecated in favor of pr_err(). However, we should prefer to use drm_err() whenever possible so we get device- specific output with the error message. In error case of kcalloc, we can simply drop DRM_ERROR(), because kcalloc already log

Re: [PATCH V2 07/16] drm/vc4: Get the rid of DRM_ERROR()

2024-07-29 Thread Maxime Ripard
On Sun, 28 Jul 2024 13:41:51 +0200, Stefan Wahren wrote: > DRM_ERROR() has been deprecated in favor of pr_err(). However, we > should prefer to use drm_err() whenever possible so we get device- > specific output with the error message. In error case of kcalloc, > we can simply drop DRM_ERROR(), bec

[PATCH V2 07/16] drm/vc4: Get the rid of DRM_ERROR()

2024-07-28 Thread Stefan Wahren
DRM_ERROR() has been deprecated in favor of pr_err(). However, we should prefer to use drm_err() whenever possible so we get device- specific output with the error message. In error case of kcalloc, we can simply drop DRM_ERROR(), because kcalloc already logs errors. Suggested-by: Maíra Canal Sig