Re: [PATCH V2 03/10] accel/amdxdna: Add hardware resource solver

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: +int aie2_max_col = XRS_MAX_COL; +module_param(aie2_max_col, int, 0600); +MODULE_PARM_DESC(aie2_max_col, "Maximum column could be used"); I think you selected the wrong type. What happens if someone sets this to a negative value?

[PATCH V2 03/10] accel/amdxdna: Add hardware resource solver

2024-08-05 Thread Lizhi Hou
The AI Engine consists of 2D array of tiles arranged as columns. Provides the basic column allocation and release functions for the tile columns. Co-developed-by: Min Ma Signed-off-by: Min Ma Signed-off-by: Lizhi Hou --- drivers/accel/amdxdna/Makefile | 1 + drivers/accel/amdxdna/aie2_p