Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-14 Thread Lizhi Hou
On 8/14/24 14:53, Jeffrey Hugo wrote: On 8/14/2024 2:24 PM, Lizhi Hou wrote: On 8/14/24 11:46, Jeffrey Hugo wrote: On 8/14/2024 12:16 PM, Lizhi Hou wrote: On 8/9/24 09:11, Jeffrey Hugo wrote: On 8/5/2024 11:39 AM, Lizhi Hou wrote: diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/a

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-14 Thread Jeffrey Hugo
On 8/14/2024 2:24 PM, Lizhi Hou wrote: On 8/14/24 11:46, Jeffrey Hugo wrote: On 8/14/2024 12:16 PM, Lizhi Hou wrote: On 8/9/24 09:11, Jeffrey Hugo wrote: On 8/5/2024 11:39 AM, Lizhi Hou wrote: diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c new file mode 10

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-14 Thread Lizhi Hou
On 8/14/24 11:46, Jeffrey Hugo wrote: On 8/14/2024 12:16 PM, Lizhi Hou wrote: On 8/9/24 09:11, Jeffrey Hugo wrote: On 8/5/2024 11:39 AM, Lizhi Hou wrote: diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c new file mode 100644 index ..3660967c00e6 -

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-14 Thread Jeffrey Hugo
On 8/14/2024 12:16 PM, Lizhi Hou wrote: On 8/9/24 09:11, Jeffrey Hugo wrote: On 8/5/2024 11:39 AM, Lizhi Hou wrote: diff --git a/drivers/accel/amdxdna/aie2_pci.c b/drivers/accel/amdxdna/aie2_pci.c new file mode 100644 index ..3660967c00e6 --- /dev/null +++ b/drivers/accel/amdxdna/

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-14 Thread Lizhi Hou
On 8/9/24 09:11, Jeffrey Hugo wrote: On 8/5/2024 11:39 AM, Lizhi Hou wrote: AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added.    - module

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-12 Thread Lizhi Hou
On 8/9/24 08:24, Carl Vanderlip wrote: On 8/5/2024 10:39 AM, Lizhi Hou wrote: > +static int aie2_init(struct amdxdna_dev *xdna) > +{ > +    struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev); > +    struct amdxdna_dev_hdl *ndev; > +    struct psp_config psp_conf; > +    const struct firmware *fw

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-09 Thread Jeffrey Hugo
On 8/5/2024 11:39 AM, Lizhi Hou wrote: AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added. - module and PCI device initialization - firm

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-09 Thread Carl Vanderlip
On 8/5/2024 10:39 AM, Lizhi Hou wrote: > +static int aie2_init(struct amdxdna_dev *xdna) > +{ > +struct pci_dev *pdev = to_pci_dev(xdna->ddev.dev); > +struct amdxdna_dev_hdl *ndev; > +struct psp_config psp_conf; > +const struct firmware *fw; > +void __iomem * const *tbl; > +

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-07 Thread Lizhi Hou
On 8/7/24 04:06, Markus Elfring wrote: If you temporarily find the circumstances too challenging for applications of scope-based resource management, I suggest to use the following statements instead (so that a bit of redundant code can be avoided). … +++ b/drivers/accel/amdxdna/aie2_pci.c

Re: [PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-07 Thread Markus Elfring
If you temporarily find the circumstances too challenging for applications of scope-based resource management, I suggest to use the following statements instead (so that a bit of redundant code can be avoided). … > +++ b/drivers/accel/amdxdna/aie2_pci.c > @@ -0,0 +1,182 @@ … > +static int aie2_

[PATCH V2 01/10] accel/amdxdna: Add a new driver for AMD AI Engine

2024-08-05 Thread Lizhi Hou
AMD AI Engine forms the core of AMD NPU and can be used for accelerating machine learning applications. Add the driver to support AI Engine integrated to AMD CPU. Only very basic functionalities are added. - module and PCI device initialization - firmware load - power up - low level hardwa