[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
On 22 May 2014 13:33, Thierry Reding wrote: > On Thu, May 22, 2014 at 12:06:16PM +0530, Rahul Sharma wrote: >> On 22 May 2014 11:51, Sachin Kamat wrote: >> > Hi Rahul, >> [snip] >> >> >> >> + clk_prepare_enable(ctx->bus_clk); >> > >> > Probably a check for its success? >> > >> >> + cl

[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Sachin Kamat
On 22 May 2014 12:06, Rahul Sharma wrote: > On 22 May 2014 11:51, Sachin Kamat wrote: >> Hi Rahul, > [snip] >>> >>> + clk_prepare_enable(ctx->bus_clk); >> >> Probably a check for its success? >> >>> + clk_prepare_enable(ctx->lcd_clk); >> > > Generally we don't check this in any of the

[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
On 22 May 2014 11:51, Sachin Kamat wrote: > Hi Rahul, [snip] >> >> + clk_prepare_enable(ctx->bus_clk); > > Probably a check for its success? > >> + clk_prepare_enable(ctx->lcd_clk); > Generally we don't check this in any of the driver. It will be quite unnecessary. Regards, Rahul Sha

[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Sachin Kamat
Hi Rahul, On 22 May 2014 10:46, Rahul Sharma wrote: > From: Rahul Sharma > > Fimd probe is accessing fimd Registers without enabling the fimd > gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled > during kernel boottime, the system hangs during boottime. > > This issue got surfac

[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Rahul Sharma
From: Rahul Sharma Fimd probe is accessing fimd Registers without enabling the fimd gate clocks. If FIMD clocks are kept disabled in Uboot or disbaled during kernel boottime, the system hangs during boottime. This issue got surfaced when verifying with sysmmu enabled. Probe of fimd Sysmmu enable

[PATCH V2] drm/exynos: enable fimd clocks in probe before accessing fimd registers

2014-05-22 Thread Thierry Reding
On Thu, May 22, 2014 at 12:06:16PM +0530, Rahul Sharma wrote: > On 22 May 2014 11:51, Sachin Kamat wrote: > > Hi Rahul, > [snip] > >> > >> + clk_prepare_enable(ctx->bus_clk); > > > > Probably a check for its success? > > > >> + clk_prepare_enable(ctx->lcd_clk); > > > > Generally we do