Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

On Tue, Feb 25, 2020 at 3:38 PM Thomas Zimmermann wrote: > Hi > > Am 23.02.20 um 05:26 schrieb tang pengchuan: > > > > > > On Sun, Feb 23, 2020 at 5:27 AM Sam Ravnborg > > wrote: > > > > Hi Kevin/tang. > > > > Thanks for the quick and detailed feedback. > >

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

Got it, thanks! On Tue, Feb 25, 2020 at 12:43 AM Emil Velikov wrote: > Hi all, > > On Fri, 21 Feb 2020 at 11:15, Kevin Tang wrote: > > > > From: Kevin Tang > > > > Adds drm support for the Unisoc's display subsystem. > > > > This is drm device and gem driver. This driver provides support for t

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

Hi Am 23.02.20 um 05:26 schrieb tang pengchuan: > > > On Sun, Feb 23, 2020 at 5:27 AM Sam Ravnborg > wrote: > > Hi Kevin/tang. > > Thanks for the quick and detailed feedback. > Your questions are addressed below. > >         Sam > > > > > > +st

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

Hi all, On Fri, 21 Feb 2020 at 11:15, Kevin Tang wrote: > > From: Kevin Tang > > Adds drm support for the Unisoc's display subsystem. > > This is drm device and gem driver. This driver provides support for the > Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. > > Cc: Orson Zha

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

On Sun, Feb 23, 2020 at 5:27 AM Sam Ravnborg wrote: > Hi Kevin/tang. > > Thanks for the quick and detailed feedback. > Your questions are addressed below. > > Sam > > > > > > +static int sprd_drm_bind(struct device *dev) > > > > +{ > > > > + struct drm_device *drm; > > > > + struc

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

On Sat, Feb 22, 2020 at 5:36 AM Sam Ravnborg wrote: > Hi Kevin. > > On Fri, Feb 21, 2020 at 03:48:52PM +0800, Kevin Tang wrote: > > From: Kevin Tang > > > > Adds drm support for the Unisoc's display subsystem. > > Thanks for the updated driver patch. > Good split of patches. > A few comments in

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

On Sun, Feb 23, 2020 at 12:26 PM tang pengchuan wrote: > > > On Sun, Feb 23, 2020 at 5:27 AM Sam Ravnborg wrote: > >> Hi Kevin/tang. >> >> Thanks for the quick and detailed feedback. >> Your questions are addressed below. >> >> Sam >> >> >> > > > +static int sprd_drm_bind(struct device *

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

Hi Kevin/tang. Thanks for the quick and detailed feedback. Your questions are addressed below. Sam > > > +static int sprd_drm_bind(struct device *dev) > > > +{ > > > + struct drm_device *drm; > > > + struct sprd_drm *sprd; > > > + int err; > > > + > > > + drm = drm_dev_a

Re: [PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

Hi Kevin. On Fri, Feb 21, 2020 at 03:48:52PM +0800, Kevin Tang wrote: > From: Kevin Tang > > Adds drm support for the Unisoc's display subsystem. Thanks for the updated driver patch. Good split of patches. A few comments in the following. Please filter in the comments as some may not apply to t

[PATCH RFC v3 2/6] drm/sprd: add Unisoc's drm kms master

From: Kevin Tang Adds drm support for the Unisoc's display subsystem. This is drm device and gem driver. This driver provides support for the Direct Rendering Infrastructure (DRI) in XFree86 4.1.0 and higher. Cc: Orson Zhai Cc: Baolin Wang Cc: Chunyan Zhang Signed-off-by: Kevin Tang --- dr