Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread Linus Torvalds
On Tue, Nov 22, 2022 at 4:25 AM Hans Verkuil wrote: > > I tracked the use of 'force' all the way back to the first git commit > (2.6.12-rc1) in the very old video-buf.c. So it is very, very old and the > reason is lost in the mists of time. Well, not entirely. For archaeology reasons, I went bac

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread David Hildenbrand
On 22.11.22 15:07, Hans Verkuil wrote: On 11/22/22 13:38, David Hildenbrand wrote: On 22.11.22 13:25, Hans Verkuil wrote: Hi Tomasz, David, On 11/8/22 05:45, Tomasz Figa wrote: Hi David, On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: FOLL_FORCE is really only for debugger access.

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread Hans Verkuil
On 11/22/22 13:38, David Hildenbrand wrote: > On 22.11.22 13:25, Hans Verkuil wrote: >> Hi Tomasz, David, >> >> On 11/8/22 05:45, Tomasz Figa wrote: >>> Hi David, >>> >>> On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: FOLL_FORCE is really only for debugger access. According to c

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread David Hildenbrand
On 22.11.22 13:25, Hans Verkuil wrote: Hi Tomasz, David, On 11/8/22 05:45, Tomasz Figa wrote: Hi David, On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: FOLL_FORCE is really only for debugger access. According to commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers ar

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-22 Thread Hans Verkuil
Hi Tomasz, David, On 11/8/22 05:45, Tomasz Figa wrote: > Hi David, > > On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: >> >> FOLL_FORCE is really only for debugger access. According to commit >> 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always >> writable"), the p

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-08 Thread David Hildenbrand
On 08.11.22 05:45, Tomasz Figa wrote: Hi David, Hi Tomasz, thanks for looking into this! On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: FOLL_FORCE is really only for debugger access. According to commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always wri

Re: [PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-07 Thread Tomasz Figa
Hi David, On Tue, Nov 8, 2022 at 1:19 AM David Hildenbrand wrote: > > FOLL_FORCE is really only for debugger access. According to commit > 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always > writable"), the pinned pages are always writable. Actually that patch is only a wo

[PATCH RFC 16/19] mm/frame-vector: remove FOLL_FORCE usage

2022-11-07 Thread David Hildenbrand
FOLL_FORCE is really only for debugger access. According to commit 707947247e95 ("media: videobuf2-vmalloc: get_userptr: buffers are always writable"), the pinned pages are always writable. FOLL_FORCE in this case seems to be a legacy leftover. Let's just remove it. Cc: Tomasz Figa Cc: Marek Szy