Re: [PATCH RFC 1/7] clk: samsung: Add enable/disable operation for PLL36XX clocks

2017-04-24 Thread Krzysztof Kozlowski
On Mon, Apr 24, 2017 at 1:12 PM, Sylwester Nawrocki wrote: > On 04/22/2017 05:22 PM, Krzysztof Kozlowski wrote: >>> @@ -354,10 +359,12 @@ static int samsung_pll36xx_set_rate(struct clk_hw >>> *hw, unsigned long drate, >>> writel_relaxed(pll_con1, pll->con_reg + 4); >>> >>> /* wait_

Re: [PATCH RFC 1/7] clk: samsung: Add enable/disable operation for PLL36XX clocks

2017-04-24 Thread Sylwester Nawrocki
On 04/22/2017 05:22 PM, Krzysztof Kozlowski wrote: [...] +static void samsung_pll3xxx_disable(struct clk_hw *hw) +{ + struct samsung_clk_pll *pll = to_clk_pll(hw); + u32 tmp; + + tmp = readl_relaxed(pll->con_reg); + tmp |= BIT(pll->enable_offs); I think you meant here:

Re: [PATCH RFC 1/7] clk: samsung: Add enable/disable operation for PLL36XX clocks

2017-04-24 Thread Sylwester Nawrocki
On 04/22/2017 04:51 AM, Stephen Boyd wrote: +static int samsung_pll3xxx_enable(struct clk_hw *hw) +{ + struct samsung_clk_pll *pll = to_clk_pll(hw); + u32 tmp; + + tmp = readl_relaxed(pll->con_reg); + tmp |= BIT(pll->enable_offs); + writel_relaxed(tmp, pll->con_reg);

Re: [PATCH RFC 1/7] clk: samsung: Add enable/disable operation for PLL36XX clocks

2017-04-23 Thread Krzysztof Kozlowski
On Fri, Apr 21, 2017 at 07:19:45PM +0200, Sylwester Nawrocki wrote: > The existing enable/disable ops for PLL35XX are made more generic > and used also for PLL36XX. This fixes issues in the kernel with > PLL36XX PLLs when the PLL has not been already enabled by bootloader. > > Signed-off-by: Sylwe

Re: [PATCH RFC 1/7] clk: samsung: Add enable/disable operation for PLL36XX clocks

2017-04-21 Thread Stephen Boyd
On 04/21, Sylwester Nawrocki wrote: > The existing enable/disable ops for PLL35XX are made more generic > and used also for PLL36XX. This fixes issues in the kernel with > PLL36XX PLLs when the PLL has not been already enabled by bootloader. > > Signed-off-by: Sylwester Nawrocki > --- > drivers/

[PATCH RFC 1/7] clk: samsung: Add enable/disable operation for PLL36XX clocks

2017-04-21 Thread Sylwester Nawrocki
The existing enable/disable ops for PLL35XX are made more generic and used also for PLL36XX. This fixes issues in the kernel with PLL36XX PLLs when the PLL has not been already enabled by bootloader. Signed-off-by: Sylwester Nawrocki --- drivers/clk/samsung/clk-pll.c | 85 +++