Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-19 Thread Lee Jones
On Fri, 06 Jan 2023, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from future changes. > > Sign

Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-09 Thread Lee Jones
On Mon, 09 Jan 2023, Daniel Thompson wrote: > On Fri, Jan 06, 2023 at 06:43:36PM +0100, Daniel Vetter wrote: > > On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > > > Instead of retrieving the backlight brightness in struct > > > backlight_properties manually, and then checking wheth

Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-09 Thread Daniel Thompson
On Fri, Jan 06, 2023 at 06:43:36PM +0100, Daniel Vetter wrote: > On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > > Instead of retrieving the backlight brightness in struct > > backlight_properties manually, and then checking whether the backlight > > should be on at all, use backlig

Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-09 Thread Daniel Thompson
On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from futur

Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-06 Thread Stephen Kitt
Hi Daniel, On Fri, 6 Jan 2023 18:43:36 +0100, Daniel Vetter wrote: > On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > > Instead of retrieving the backlight brightness in struct > > backlight_properties manually, and then checking whether the backlight > > should be on at all, use b

Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-06 Thread Sam Ravnborg
Hi Stephen, On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates th

Re: [PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-06 Thread Daniel Vetter
On Fri, Jan 06, 2023 at 05:48:52PM +0100, Stephen Kitt wrote: > Instead of retrieving the backlight brightness in struct > backlight_properties manually, and then checking whether the backlight > should be on at all, use backlight_get_brightness() which does all > this and insulates this from futur

[PATCH RESEND 1/4] backlight: aat2870: Use backlight helper

2023-01-06 Thread Stephen Kitt
Instead of retrieving the backlight brightness in struct backlight_properties manually, and then checking whether the backlight should be on at all, use backlight_get_brightness() which does all this and insulates this from future changes. Signed-off-by: Stephen Kitt --- drivers/video/backlight/