Re: [PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-24 Thread Kajtár Zsolt
Hello Thomas! Wanted to answer earlier but things took time, and a lot more than expected. > First of all, commit 779121e9f175 ("fbdev: Support for byte-reversed > framebuffer formats") isn't super complicated AFAICT. I can be > implemented in the sys_ helpers as well. It seems like you initially

Re: [PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-10 Thread Thomas Zimmermann
Hi Am 08.02.25 um 01:51 schrieb Kajtár Zsolt: Hello Thomas! No it's not. Major code abstractions behind preprocessor tokens are terrible to maintain. Hmm, don't get me wrong but I'm not sure if the changes were really checked in detail. At first sight it might look like I'm adding tons of new

Re: [PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-09 Thread Kajtár Zsolt
Hello Thomas! > No it's not. Major code abstractions behind preprocessor tokens are > terrible to maintain. Hmm, don't get me wrong but I'm not sure if the changes were really checked in detail. At first sight it might look like I'm adding tons of new macro ridden code in those header files repl

[PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-07 Thread Zsolt Kajtar
In 68648ed1f58d98b8e8d994022e5e25331fbfe42a the drawing routines were duplicated to have separate I/O and system memory versions. Later the pixel reversing in 779121e9f17525769c04a00475fd85600c8c04eb was only added to the I/O version and not to system. That's unfortunate as reversing is not somet

Re: [PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-07 Thread Thomas Zimmermann
Hi Am 07.02.25 um 05:18 schrieb Zsolt Kajtar: In 68648ed1f58d98b8e8d994022e5e25331fbfe42a the drawing routines were duplicated to have separate I/O and system memory versions. Later the pixel reversing in 779121e9f17525769c04a00475fd85600c8c04eb was only added to the I/O version and not to sys

Re: [PATCH RESEND 00/13] fbdev: core: Deduplicate cfb/sys drawing fbops

2025-02-06 Thread Helge Deller
On 2/7/25 05:18, Zsolt Kajtar wrote: In 68648ed1f58d98b8e8d994022e5e25331fbfe42a the drawing routines were duplicated to have separate I/O and system memory versions. Later the pixel reversing in 779121e9f17525769c04a00475fd85600c8c04eb was only added to the I/O version and not to system. That'