Re: [PATCH RESEND] drm: fix crash in drm_minor_alloc_release

2022-11-08 Thread Stanislaw Gruszka
On Mon, Nov 07, 2022 at 05:56:36PM +0200, Ville Syrjälä wrote: > On Mon, Nov 07, 2022 at 04:40:41PM +0100, Stanislaw Gruszka wrote: > > On Mon, Nov 07, 2022 at 05:10:48PM +0200, Ville Syrjälä wrote: > > > On Mon, Nov 07, 2022 at 03:45:00PM +0100, Stanislaw Gruszka wrote: > > > > index 8214a0b1ab7f.

Re: [PATCH RESEND] drm: fix crash in drm_minor_alloc_release

2022-11-07 Thread Ville Syrjälä
On Mon, Nov 07, 2022 at 04:40:41PM +0100, Stanislaw Gruszka wrote: > On Mon, Nov 07, 2022 at 05:10:48PM +0200, Ville Syrjälä wrote: > > On Mon, Nov 07, 2022 at 03:45:00PM +0100, Stanislaw Gruszka wrote: > > > index 8214a0b1ab7f..e3a1243dd2ae 100644 > > > --- a/drivers/gpu/drm/drm_drv.c > > > +++ b/

Re: [PATCH RESEND] drm: fix crash in drm_minor_alloc_release

2022-11-07 Thread Stanislaw Gruszka
On Mon, Nov 07, 2022 at 05:10:48PM +0200, Ville Syrjälä wrote: > On Mon, Nov 07, 2022 at 03:45:00PM +0100, Stanislaw Gruszka wrote: > > index 8214a0b1ab7f..e3a1243dd2ae 100644 > > --- a/drivers/gpu/drm/drm_drv.c > > +++ b/drivers/gpu/drm/drm_drv.c > > @@ -102,7 +102,8 @@ static void drm_minor_alloc

Re: [PATCH RESEND] drm: fix crash in drm_minor_alloc_release

2022-11-07 Thread Ville Syrjälä
On Mon, Nov 07, 2022 at 03:45:00PM +0100, Stanislaw Gruszka wrote: > If drm_sysfs_minor_alloc() fail in drm_minor_alloc() we can end up > freeing invalid minor->kdev pointer and drm_minor_alloc_release() > will crash like below: > > RIP: 0010:kobject_put+0x19/0x1c0 > RSP: 0018:bc7001637c38 EFL

[PATCH RESEND] drm: fix crash in drm_minor_alloc_release

2022-11-07 Thread Stanislaw Gruszka
If drm_sysfs_minor_alloc() fail in drm_minor_alloc() we can end up freeing invalid minor->kdev pointer and drm_minor_alloc_release() will crash like below: RIP: 0010:kobject_put+0x19/0x1c0 RSP: 0018:bc7001637c38 EFLAGS: 00010282 RAX: a8d6deb0 RBX: RCX: 9cb5912d4540