Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check

Hi, On Mon, Sep 09, 2024 at 02:33:59PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the failure. > > Cc: sta...@vger.kernel.org > Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the p

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers

Alain Volmat wrote: > Hi, > > I probably went a bit fast on the commit message. It seems to me that > the Fixes line would be probably better with below one instead. > > Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes") > > The same fix is actually necessary for all planes

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers

Hi, I probably went a bit fast on the commit message. It seems to me that the Fixes line would be probably better with below one instead. Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes") The same fix is actually necessary for all planes (cursor / gdp / hqvdp), which is rel

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check

Hi, Thank you for your patch. Acked-by: Alain Volmat Regards, Alain On Mon, Sep 09, 2024 at 02:33:59PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the failure. > > Cc: sta...@vger.kernel.o

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers

Hi, Thanks for your patch. Acked-by: Alain Volmat Regards, Alain On Mon, Aug 26, 2024 at 01:26:52PM +0800, Ma Ke wrote: > The return value of drm_atomic_get_crtc_state() needs to be > checked. To avoid use of error pointer 'crtc_state' in case > of the failure. > > Cc: sta...@vger.kernel.org

[PATCH RESEND] drm/sti: avoid potential dereference of error pointers in sti_gdp_atomic_check

The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Cc: sta...@vger.kernel.org Fixes: dd86dc2f9ae1 ("drm/sti: implement atomic_check for the planes") Signed-off-by: Ma Ke --- drivers/gpu/drm/sti/sti_gdp.c | 3 +++

Re: [PATCH RESEND] drm/sti: avoid potential dereference of error pointers

Le 26/08/2024 à 07:26, Ma Ke a écrit : The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Cc: sta...@vger.kernel.org Fixes: dec92020671c ("drm: Use the state pointer directly in planes atomic_check") Signed

[PATCH RESEND] drm/sti: avoid potential dereference of error pointers

The return value of drm_atomic_get_crtc_state() needs to be checked. To avoid use of error pointer 'crtc_state' in case of the failure. Cc: sta...@vger.kernel.org Fixes: dec92020671c ("drm: Use the state pointer directly in planes atomic_check") Signed-off-by: Ma Ke --- drivers/gpu/drm/sti/sti