Re: [PATCH RESEND] drm/lease: fix potential race in fill_object_idr

2020-03-19 Thread Qiujun Huang
On Wed, Mar 18, 2020 at 3:34 PM Daniel Vetter wrote: > > On Tue, Mar 17, 2020 at 11:33 PM Qiujun Huang wrote: > > > > On Wed, Mar 18, 2020 at 1:02 AM Daniel Vetter wrote: > > > > > > On Mon, Mar 16, 2020 at 03:18:23PM +0800, Qiujun Huang wrote: > > > > We should hold idr_mutex for idr_alloc. > >

Re: [PATCH RESEND] drm/lease: fix potential race in fill_object_idr

2020-03-18 Thread Daniel Vetter
On Tue, Mar 17, 2020 at 11:33 PM Qiujun Huang wrote: > > On Wed, Mar 18, 2020 at 1:02 AM Daniel Vetter wrote: > > > > On Mon, Mar 16, 2020 at 03:18:23PM +0800, Qiujun Huang wrote: > > > We should hold idr_mutex for idr_alloc. > > > > > > Signed-off-by: Qiujun Huang > > > > I've not seen the firs

Re: [PATCH RESEND] drm/lease: fix potential race in fill_object_idr

2020-03-17 Thread Qiujun Huang
On Wed, Mar 18, 2020 at 1:02 AM Daniel Vetter wrote: > > On Mon, Mar 16, 2020 at 03:18:23PM +0800, Qiujun Huang wrote: > > We should hold idr_mutex for idr_alloc. > > > > Signed-off-by: Qiujun Huang > > I've not seen the first version of this anywhere in my inbox, not sure > where that got lost.

Re: [PATCH RESEND] drm/lease: fix potential race in fill_object_idr

2020-03-17 Thread Daniel Vetter
On Mon, Mar 16, 2020 at 03:18:23PM +0800, Qiujun Huang wrote: > We should hold idr_mutex for idr_alloc. > > Signed-off-by: Qiujun Huang I've not seen the first version of this anywhere in my inbox, not sure where that got lost. Anyway, this seems like a false positive - I'm assuming this was ca

[PATCH RESEND] drm/lease: fix potential race in fill_object_idr

2020-03-16 Thread Qiujun Huang
We should hold idr_mutex for idr_alloc. Signed-off-by: Qiujun Huang --- drivers/gpu/drm/drm_lease.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/drivers/gpu/drm/drm_lease.c b/drivers/gpu/drm/drm_lease.c index b481caf..427ee21 100644 --- a/drivers/gpu/drm/drm_lease