Re: [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*

2018-10-23 Thread Rob Clark
On Tue, Oct 23, 2018 at 12:41 PM Sean Paul wrote: > > On Mon, Oct 22, 2018 at 08:22:57PM +0100, Chris Wilson wrote: > > Quoting Mamta Shukla (2018-10-20 18:49:26) > > > Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate > > > drm-formatted specific log messages so that it will b

Re: [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*

2018-10-23 Thread Sean Paul
On Mon, Oct 22, 2018 at 08:22:57PM +0100, Chris Wilson wrote: > Quoting Mamta Shukla (2018-10-20 18:49:26) > > Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate > > drm-formatted specific log messages so that it will be easy to > > differentiate in case of multiple instances of

Re: [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*

2018-10-22 Thread Chris Wilson
Quoting Mamta Shukla (2018-10-20 18:49:26) > Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate > drm-formatted specific log messages so that it will be easy to > differentiate in case of multiple instances of driver. Do you not think this is a bit backwards? Both dev_* and DRM_

Re: [PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*

2018-10-22 Thread Sam Ravnborg
Hi Mamta. On Sat, Oct 20, 2018 at 11:19:26PM +0530, Mamta Shukla wrote: > Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate > drm-formatted specific log messages so that it will be easy to > differentiate in case of multiple instances of driver. While touching all these lines

[PATCH DRM] drm: msm: Use DRM_DEV_* instead of dev_*

2018-10-22 Thread Mamta Shukla
Use DRM_DEV_INFO/ERROR/WARN instead of dev_info/err/debug to generate drm-formatted specific log messages so that it will be easy to differentiate in case of multiple instances of driver. Signed-off-by: Mamta Shukla --- drivers/gpu/drm/msm/adreno/a3xx_gpu.c | 4 +-- drivers/gpu/drm/