Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-09 Thread Michel Dänzer
On 2019-09-07 4:58 p.m., Alex Deucher wrote: > > The patch shuffling doesn't help, but regardless, the same thing could > happen even with a direct committer tree if someone missed the tag when > committing. True, but in the latter case it would at least be possible to add tags referencing persist

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-07 Thread Joe Perches
On Wed, 2019-09-04 at 08:08 -0400, Sasha Levin wrote: > it's better to get > it right rather than to be done quickly :) That also applies to the initial selection of patches for the stable trees. ___ dri-devel mailing list dri-devel@lists.freedesktop.o

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-07 Thread Alex Deucher
On Tue, Sep 3, 2019 at 4:16 PM Daniel Vetter wrote: > > On Tue, Sep 3, 2019 at 10:01 PM Sasha Levin wrote: > > > > On Tue, Sep 03, 2019 at 07:03:47PM +0200, Greg KH wrote: > > >On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote: > > >> On 2019-09-03 6:23 p.m., Sasha Levin wrote: > > >>

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-04 Thread Michel Dänzer
On 2019-09-04 2:08 p.m., Sasha Levin wrote: > > FWIW, I've added another test to my scripts to try and catch these cases > (Revert "%s"). It'll slow down the scripts a bit but it's better to get > it right rather than to be done quickly :) Indeed, thanks! And again sorry for the brouhaha, I just

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-04 Thread Sasha Levin
On Wed, Sep 04, 2019 at 10:55:10AM +0200, Michel Dänzer wrote: On 2019-09-03 10:16 p.m., Daniel Vetter wrote: On Tue, Sep 3, 2019 at 10:01 PM Sasha Levin wrote: On Tue, Sep 03, 2019 at 07:03:47PM +0200, Greg KH wrote: On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote: On 2019-09-

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-04 Thread Michel Dänzer
On 2019-09-03 10:16 p.m., Daniel Vetter wrote: > On Tue, Sep 3, 2019 at 10:01 PM Sasha Levin wrote: >> On Tue, Sep 03, 2019 at 07:03:47PM +0200, Greg KH wrote: >>> On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote: On 2019-09-03 6:23 p.m., Sasha Levin wrote: > From: Yu Zhao >

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-03 Thread Daniel Vetter
On Tue, Sep 3, 2019 at 10:01 PM Sasha Levin wrote: > > On Tue, Sep 03, 2019 at 07:03:47PM +0200, Greg KH wrote: > >On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote: > >> On 2019-09-03 6:23 p.m., Sasha Levin wrote: > >> > From: Yu Zhao > >> > > >> > [ Upstream commit 89f23b6efef554766

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-03 Thread Sasha Levin
On Tue, Sep 03, 2019 at 07:03:47PM +0200, Greg KH wrote: On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote: On 2019-09-03 6:23 p.m., Sasha Levin wrote: > From: Yu Zhao > > [ Upstream commit 89f23b6efef554766177bf51aa754bce14c3e7da ] Hold your horses! This commit and c4a32b266da7bb

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-03 Thread Greg KH
On Tue, Sep 03, 2019 at 06:40:43PM +0200, Michel Dänzer wrote: > On 2019-09-03 6:23 p.m., Sasha Levin wrote: > > From: Yu Zhao > > > > [ Upstream commit 89f23b6efef554766177bf51aa754bce14c3e7da ] > > Hold your horses! > > This commit and c4a32b266da7bb702e60381ca0c35eaddbc89a6c had to be > reve

Re: [PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-03 Thread Michel Dänzer
On 2019-09-03 6:23 p.m., Sasha Levin wrote: > From: Yu Zhao > > [ Upstream commit 89f23b6efef554766177bf51aa754bce14c3e7da ] Hold your horses! This commit and c4a32b266da7bb702e60381ca0c35eaddbc89a6c had to be reverted, as they caused regressions. See commits 25ec429e86bb790e40387a550f0501d0ac5

[PATCH AUTOSEL 4.19 044/167] drm/amdgpu: validate user pitch alignment

2019-09-03 Thread Sasha Levin
From: Yu Zhao [ Upstream commit 89f23b6efef554766177bf51aa754bce14c3e7da ] Userspace may request pitch alignment that is not supported by GPU. Some requests 32, but GPU ignores it and uses default 64 when cpp is 4. If GEM object is allocated based on the smaller alignment, GPU DMA will go out of