Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-20 Thread Lyude Paul
On Thu, 2021-09-16 at 12:32 +0200, Hans de Goede wrote: > > I'm fine with refactoring this a bit and adding > an intel_modeset_probe_defer() helper for this, I assume I should also > move the vga_switcheroo_client_probe_defer(pdev) check there? > > As you suggested yourself in your reply to the c

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-17 Thread Ville Syrjälä
On Fri, Sep 17, 2021 at 06:42:04PM +0200, Hans de Goede wrote: > Hi, > > On 9/17/21 6:25 PM, Ville Syrjälä wrote: > > On Fri, Sep 17, 2021 at 04:37:14PM +0200, Hans de Goede wrote: > >> Hi, > >> > >> On 9/16/21 3:45 PM, Ville Syrjälä wrote: > >>> On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de G

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-17 Thread Hans de Goede
Hi, On 9/17/21 6:25 PM, Ville Syrjälä wrote: > On Fri, Sep 17, 2021 at 04:37:14PM +0200, Hans de Goede wrote: >> Hi, >> >> On 9/16/21 3:45 PM, Ville Syrjälä wrote: >>> On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de Goede wrote: Add support for eDP panels with a built-in privacy screen usin

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-17 Thread Ville Syrjälä
On Fri, Sep 17, 2021 at 04:37:14PM +0200, Hans de Goede wrote: > Hi, > > On 9/16/21 3:45 PM, Ville Syrjälä wrote: > > On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de Goede wrote: > >> Add support for eDP panels with a built-in privacy screen using the > >> new drm_privacy_screen class. > >> > >>

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-17 Thread Hans de Goede
Hi, On 9/16/21 3:45 PM, Ville Syrjälä wrote: > On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> One thing which stands out here is the addition of these 2 lines to >> intel_a

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-17 Thread Hans de Goede
Hi, On 9/16/21 4:04 PM, Ville Syrjälä wrote: > On Thu, Sep 16, 2021 at 12:40:11PM +0300, Jani Nikula wrote: >> >> Cc: Ville for input here, see question inline. >> >> On Mon, 06 Sep 2021, Hans de Goede wrote: >>> Add support for eDP panels with a built-in privacy screen using the >>> new drm_priv

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-16 Thread Ville Syrjälä
On Thu, Sep 16, 2021 at 12:40:11PM +0300, Jani Nikula wrote: > > Cc: Ville for input here, see question inline. > > On Mon, 06 Sep 2021, Hans de Goede wrote: > > Add support for eDP panels with a built-in privacy screen using the > > new drm_privacy_screen class. > > > > One thing which stands o

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-16 Thread Ville Syrjälä
On Mon, Sep 06, 2021 at 09:35:19AM +0200, Hans de Goede wrote: > Add support for eDP panels with a built-in privacy screen using the > new drm_privacy_screen class. > > One thing which stands out here is the addition of these 2 lines to > intel_atomic_commit_tail: > > for_each_new_connector

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-16 Thread Hans de Goede
Hi, On 9/16/21 11:40 AM, Jani Nikula wrote: > > Cc: Ville for input here, see question inline. > > On Mon, 06 Sep 2021, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> One thing which stands out here is the addit

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-16 Thread Jani Nikula
Cc: Ville for input here, see question inline. On Mon, 06 Sep 2021, Hans de Goede wrote: > Add support for eDP panels with a built-in privacy screen using the > new drm_privacy_screen class. > > One thing which stands out here is the addition of these 2 lines to > intel_atomic_commit_tail: > >

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-16 Thread Hans de Goede
Hi, On 9/15/21 11:11 PM, Lyude Paul wrote: > On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: >> Add support for eDP panels with a built-in privacy screen using the >> new drm_privacy_screen class. >> >> One thing which stands out here is the addition of these 2 lines to >> intel_atomic_com

Re: [PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-15 Thread Lyude Paul
On Mon, 2021-09-06 at 09:35 +0200, Hans de Goede wrote: > Add support for eDP panels with a built-in privacy screen using the > new drm_privacy_screen class. > > One thing which stands out here is the addition of these 2 lines to > intel_atomic_commit_tail: > > for_each_new_connector_in_s

[PATCH 9/9] drm/i915: Add privacy-screen support

2021-09-06 Thread Hans de Goede
Add support for eDP panels with a built-in privacy screen using the new drm_privacy_screen class. One thing which stands out here is the addition of these 2 lines to intel_atomic_commit_tail: for_each_new_connector_in_state(&state->base, connector, ... drm_connector_update

[PATCH 9/9] drm/i915: Add privacy-screen support

2020-07-08 Thread Hans de Goede
Add support for eDP panels with a built-in privacy screen using the new drm_privacy_screen class. One thing which stands out here is the addition of these 2 lines to intel_atomic_commit_tail: for_each_new_connector_in_state(&state->base, connector, ... drm_connector_update