Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Felix Kuehling
Am 2021-04-14 um 8:25 a.m. schrieb Daniel Vetter: >> Sorry I though that this would be obvious :) >> >> I've already pushed the patch in the morning, but going to keep that in >> mind for the next time. > I'll keep reminding you to pls elaborate more in commit messages, it's > coming up every once

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Christian König
Am 14.04.21 um 14:47 schrieb Daniel Vetter: On Wed, Apr 14, 2021 at 2:43 PM Christian König wrote: Am 14.04.21 um 14:25 schrieb Daniel Vetter: On Wed, Apr 14, 2021 at 12:49 PM Christian König wrote: Am 14.04.21 um 12:26 schrieb Daniel Vetter: On Wed, Apr 14, 2021 at 11:19:41AM +0200, Christ

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Daniel Vetter
On Wed, Apr 14, 2021 at 2:43 PM Christian König wrote: > > Am 14.04.21 um 14:25 schrieb Daniel Vetter: > > On Wed, Apr 14, 2021 at 12:49 PM Christian König > > wrote: > >> Am 14.04.21 um 12:26 schrieb Daniel Vetter: > >>> On Wed, Apr 14, 2021 at 11:19:41AM +0200, Christian König wrote: > Am

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Christian König
Am 14.04.21 um 14:25 schrieb Daniel Vetter: On Wed, Apr 14, 2021 at 12:49 PM Christian König wrote: Am 14.04.21 um 12:26 schrieb Daniel Vetter: On Wed, Apr 14, 2021 at 11:19:41AM +0200, Christian König wrote: Am 14.04.21 um 11:15 schrieb Daniel Vetter: On Wed, Apr 14, 2021 at 08:51:51AM +020

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Daniel Vetter
On Wed, Apr 14, 2021 at 12:49 PM Christian König wrote: > > Am 14.04.21 um 12:26 schrieb Daniel Vetter: > > On Wed, Apr 14, 2021 at 11:19:41AM +0200, Christian König wrote: > >> Am 14.04.21 um 11:15 schrieb Daniel Vetter: > >>> On Wed, Apr 14, 2021 at 08:51:51AM +0200, Christian König wrote: > >>>

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Christian König
Am 14.04.21 um 12:26 schrieb Daniel Vetter: On Wed, Apr 14, 2021 at 11:19:41AM +0200, Christian König wrote: Am 14.04.21 um 11:15 schrieb Daniel Vetter: On Wed, Apr 14, 2021 at 08:51:51AM +0200, Christian König wrote: Am 14.04.21 um 08:48 schrieb Felix Kuehling: Pages in SG BOs were not alloc

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Daniel Vetter
On Wed, Apr 14, 2021 at 11:19:41AM +0200, Christian König wrote: > Am 14.04.21 um 11:15 schrieb Daniel Vetter: > > On Wed, Apr 14, 2021 at 08:51:51AM +0200, Christian König wrote: > > > Am 14.04.21 um 08:48 schrieb Felix Kuehling: > > > > Pages in SG BOs were not allocated by TTM. So don't count th

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Christian König
Am 14.04.21 um 11:15 schrieb Daniel Vetter: On Wed, Apr 14, 2021 at 08:51:51AM +0200, Christian König wrote: Am 14.04.21 um 08:48 schrieb Felix Kuehling: Pages in SG BOs were not allocated by TTM. So don't count them against TTM's pages limit. Signed-off-by: Felix Kuehling Reviewed-by: Chris

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Daniel Vetter
On Wed, Apr 14, 2021 at 08:51:51AM +0200, Christian König wrote: > Am 14.04.21 um 08:48 schrieb Felix Kuehling: > > Pages in SG BOs were not allocated by TTM. So don't count them against > > TTM's pages limit. > > > > Signed-off-by: Felix Kuehling > > Reviewed-by: Christian König > > Going to

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-14 Thread Daniel Vetter
On Wed, Apr 14, 2021 at 02:46:20AM -0400, Felix Kuehling wrote: > Pages in SG BOs were not allocated by TTM. So don't count them against > TTM's pages limit. > > Signed-off-by: Felix Kuehling This sounds like papering over the lack of shrinker in ttm. Do we guarantee that someone else has alread

Re: [PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-13 Thread Christian König
Am 14.04.21 um 08:48 schrieb Felix Kuehling: Pages in SG BOs were not allocated by TTM. So don't count them against TTM's pages limit. Signed-off-by: Felix Kuehling Reviewed-by: Christian König Going to pick that one up for inclusion in drm-misc-next. Regards, Christian. --- drivers/gp

[PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-13 Thread Felix Kuehling
Pages in SG BOs were not allocated by TTM. So don't count them against TTM's pages limit. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/ttm/ttm_tt.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm

[PATCH 8/9] drm/ttm: Don't count pages in SG BOs against pages_limit

2021-04-13 Thread Felix Kuehling
Pages in SG BOs were not allocated by TTM. So don't count them against TTM's pages limit. Signed-off-by: Felix Kuehling --- drivers/gpu/drm/ttm/ttm_tt.c | 27 ++- 1 file changed, 18 insertions(+), 9 deletions(-) diff --git a/drivers/gpu/drm/ttm/ttm_tt.c b/drivers/gpu/drm