Re: [PATCH 8/9] accel/rocket: Add job submission IOCTL

2024-09-11 Thread Markus Elfring
… > +++ b/drivers/accel/rocket/rocket_job.h > @@ -0,0 +1,49 @@ … > +#ifndef __ROCKET_JOB_H__ > +#define __ROCKET_JOB_H__ … I suggest to omit leading underscores from such identifiers. https://wiki.sei.cmu.edu/confluence/display/c/DCL37-C.+Do+not+declare+or+define+a+reserved+identifier Regards, Ma

Re: [PATCH 8/9] accel/rocket: Add job submission IOCTL

2024-09-11 Thread Markus Elfring
… > +++ b/drivers/accel/rocket/rocket_job.c > @@ -0,0 +1,708 @@ … > +static int rocket_job_push(struct rocket_job *job) > +{ … > + mutex_lock(&rdev->sched_lock); > + drm_sched_job_arm(&job->base); … > + drm_sched_entity_push_job(&job->base); > + > + mutex_unlock(&rdev->sched_lock);

Re: [PATCH 8/9] accel/rocket: Add job submission IOCTL

2024-06-14 Thread Jeffrey Hugo
On 6/12/2024 7:53 AM, Tomeu Vizoso wrote: Using the DRM GPU scheduler infrastructure, with a scheduler for each core. Userspace can decide for a series of tasks to be executed sequentially in the same core, so SRAM locality can be taken advantage of. The job submission code was intially based o

Re: [PATCH 8/9] accel/rocket: Add job submission IOCTL

2024-06-13 Thread kernel test robot
: 83a7eefedc9b56fe7bfeff13b6c7356688ffa670 patch link: https://lore.kernel.org/r/20240612-6-10-rocket-v1-8-060e48eea250%40tomeuvizoso.net patch subject: [PATCH 8/9] accel/rocket: Add job submission IOCTL config: hexagon-allmodconfig (https://download.01.org/0day-ci/archive/20240613/202406131640.wbbarmbr

[PATCH 8/9] accel/rocket: Add job submission IOCTL

2024-06-12 Thread Tomeu Vizoso
Using the DRM GPU scheduler infrastructure, with a scheduler for each core. Userspace can decide for a series of tasks to be executed sequentially in the same core, so SRAM locality can be taken advantage of. The job submission code was intially based on Panfrost. Signed-off-by: Tomeu Vizoso --