Re: [PATCH 8/8] drm/panfrost: Make sure the shrinker does not reclaim referenced BOs

2019-12-02 Thread Boris Brezillon
On Mon, 2 Dec 2019 12:50:20 + Robin Murphy wrote: > On 29/11/2019 1:59 pm, Boris Brezillon wrote: > > Userspace might tag a BO purgeable while it's still referenced by GPU > > jobs. We need to make sure the shrinker does not purge such BOs until > > all jobs referencing it are finished. >

Re: [PATCH 8/8] drm/panfrost: Make sure the shrinker does not reclaim referenced BOs

2019-12-02 Thread Robin Murphy
On 29/11/2019 1:59 pm, Boris Brezillon wrote: Userspace might tag a BO purgeable while it's still referenced by GPU jobs. We need to make sure the shrinker does not purge such BOs until all jobs referencing it are finished. Nit: for extra robustness, perhaps it's worth using the refcount_t API

Re: [PATCH 8/8] drm/panfrost: Make sure the shrinker does not reclaim referenced BOs

2019-11-29 Thread Steven Price
On 29/11/2019 16:07, Boris Brezillon wrote: > On Fri, 29 Nov 2019 15:48:15 + > Steven Price wrote: > >> On 29/11/2019 13:59, Boris Brezillon wrote: >>> Userspace might tag a BO purgeable while it's still referenced by GPU >>> jobs. We need to make sure the shrinker does not purge such BOs unt

Re: [PATCH 8/8] drm/panfrost: Make sure the shrinker does not reclaim referenced BOs

2019-11-29 Thread Boris Brezillon
On Fri, 29 Nov 2019 15:48:15 + Steven Price wrote: > On 29/11/2019 13:59, Boris Brezillon wrote: > > Userspace might tag a BO purgeable while it's still referenced by GPU > > jobs. We need to make sure the shrinker does not purge such BOs until > > all jobs referencing it are finished. > > >

Re: [PATCH 8/8] drm/panfrost: Make sure the shrinker does not reclaim referenced BOs

2019-11-29 Thread Steven Price
On 29/11/2019 13:59, Boris Brezillon wrote: > Userspace might tag a BO purgeable while it's still referenced by GPU > jobs. We need to make sure the shrinker does not purge such BOs until > all jobs referencing it are finished. > > Fixes: 013b65101315 ("drm/panfrost: Add madvise and shrinker suppo

[PATCH 8/8] drm/panfrost: Make sure the shrinker does not reclaim referenced BOs

2019-11-29 Thread Boris Brezillon
Userspace might tag a BO purgeable while it's still referenced by GPU jobs. We need to make sure the shrinker does not purge such BOs until all jobs referencing it are finished. Fixes: 013b65101315 ("drm/panfrost: Add madvise and shrinker support") Cc: Signed-off-by: Boris Brezillon --- drivers