[PATCH 7/9] drm/omap: fix omap_crtc_flush() to handle the workqueue

2014-09-09 Thread Tomi Valkeinen
On 09/09/14 13:43, Rob Clark wrote: > Although, I wonder if some waitqueue scheme would be a bit more sane.. > ie. end of apply_worker, if there is nothing more queued up, signal > the event that _flush() is waiting on. Maybe, but we would still need either the separate apply_lock, or unlock the

[PATCH 7/9] drm/omap: fix omap_crtc_flush() to handle the workqueue

2014-09-09 Thread Tomi Valkeinen
On 08/09/14 16:31, Daniel Vetter wrote: > On Mon, Sep 08, 2014 at 04:03:18PM +0300, Tomi Valkeinen wrote: >> On 03/09/14 17:27, Daniel Vetter wrote: >>> On Wed, Sep 03, 2014 at 02:55:08PM +0300, Tomi Valkeinen wrote: omap_crtc_flush() is used to wait for scheduled work to be done for the

[PATCH 7/9] drm/omap: fix omap_crtc_flush() to handle the workqueue

2014-09-09 Thread Rob Clark
On Tue, Sep 9, 2014 at 3:07 AM, Tomi Valkeinen wrote: > lockdep won't complain though since you essentially open-code a workqueue_flush, and lockdep also doesn't complain about all possible deadlocks (due to some design issues with lockdep). >>> >>> What do you mean "open-code a wor

[PATCH 7/9] drm/omap: fix omap_crtc_flush() to handle the workqueue

2014-09-08 Thread Tomi Valkeinen
On 03/09/14 17:27, Daniel Vetter wrote: > On Wed, Sep 03, 2014 at 02:55:08PM +0300, Tomi Valkeinen wrote: >> omap_crtc_flush() is used to wait for scheduled work to be done for the >> give crtc. However, it's not quite right at the moment. >> >> omap_crtc_flush() does wait for work that is ran via

[PATCH 7/9] drm/omap: fix omap_crtc_flush() to handle the workqueue

2014-09-08 Thread Daniel Vetter
On Mon, Sep 08, 2014 at 04:03:18PM +0300, Tomi Valkeinen wrote: > On 03/09/14 17:27, Daniel Vetter wrote: > > On Wed, Sep 03, 2014 at 02:55:08PM +0300, Tomi Valkeinen wrote: > >> omap_crtc_flush() is used to wait for scheduled work to be done for the > >> give crtc. However, it's not quite right at

[PATCH 7/9] drm/omap: fix omap_crtc_flush() to handle the workqueue

2014-09-03 Thread Daniel Vetter
On Wed, Sep 03, 2014 at 02:55:08PM +0300, Tomi Valkeinen wrote: > omap_crtc_flush() is used to wait for scheduled work to be done for the > give crtc. However, it's not quite right at the moment. > > omap_crtc_flush() does wait for work that is ran via vsync irq to be > done. However, work is also

[PATCH 7/9] drm/omap: fix omap_crtc_flush() to handle the workqueue

2014-09-03 Thread Tomi Valkeinen
omap_crtc_flush() is used to wait for scheduled work to be done for the give crtc. However, it's not quite right at the moment. omap_crtc_flush() does wait for work that is ran via vsync irq to be done. However, work is also queued to the driver's priv->wq workqueue, which is not handled by omap_c