Re: [PATCH 7/9] drm/meson: dw-hdmi: use matched data

2024-08-19 Thread Neil Armstrong
On 30/07/2024 14:50, Jerome Brunet wrote: Using several string comparisons with if/else if/else clauses is fairly inefficient and does not scale well. Inefficient in which way ? speed ? code size ? It doesn't scale, but AFAIK Amlogic stopped using the Synopsys DWC controller after the G12B So

Re: [PATCH 7/9] drm/meson: dw-hdmi: use matched data

2024-08-07 Thread Jerome Brunet
On Tue 06 Aug 2024 at 23:03, Martin Blumenstingl wrote: > Hi Jerome, > > On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: > [...] >> + }, { >> + .limit = 297000, >> + .regs = gxbb_3g_regs, >> + .reg_num = ARRAY_SIZE(gxbb_3g_regs) > Just as a s

Re: [PATCH 7/9] drm/meson: dw-hdmi: use matched data

2024-08-06 Thread Martin Blumenstingl
Hi Jerome, On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: [...] > + }, { > + .limit = 297000, > + .regs = gxbb_3g_regs, > + .reg_num = ARRAY_SIZE(gxbb_3g_regs) Just as a side-note: this looked odd when reading for the first time as I thought t

[PATCH 7/9] drm/meson: dw-hdmi: use matched data

2024-07-30 Thread Jerome Brunet
Using several string comparisons with if/else if/else clauses is fairly inefficient and does not scale well. Use matched data to tweak the driver depending on the matched SoC instead. Signed-off-by: Jerome Brunet --- drivers/gpu/drm/meson/meson_dw_hdmi.c | 209 +- 1 file