Yeah, agree. That function is quite critical for command stream parsing
and patching.
Christian.
Am 20.05.2014 18:16, schrieb Marek Ol??k:
> I think the function should stay in the header file. It's used in
> performance-critical code, so we want it to be inlined.
>
> Marek
>
> On Fri, May 16, 2
I think the function should stay in the header file. It's used in
performance-critical code, so we want it to be inlined.
Marek
On Fri, May 16, 2014 at 11:43 PM, Andi Kleen wrote:
> From: Andi Kleen
>
> Saves about 5k of text
>
>textdata bss dec hex filename
> 14080360
On Tue, May 20, 2014 at 06:16:48PM +0200, Marek Ol??k wrote:
> I think the function should stay in the header file. It's used in
> performance-critical code, so we want it to be inlined.
This doesn't make any sense. If it's talking to the hardware it will
be dominated by the cache misses.
-Andi
From: Andi Kleen
Saves about 5k of text
textdata bss dec hex filename
140803602008168 1507328 1759585610c7dd0 vmlinux-before-radeon
140749782008168 1507328 1759047410c68ca vmlinux-radeon
Cc: alexander.deucher at amd.com
Cc: dri-devel at lists.f
