[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-06 Thread Keith Packard
Kristian H?gsberg writes: > I'm OK with either approach. It does seem like cleaning up the DRI > driver interface is orthogonal to enabling the __DRIimage based > getBuffer callout though. We should probably not merge what we don't want to maintain though; let's decide over lunch. I don't think

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-06 Thread Kristian Høgsberg
On Wed, Nov 6, 2013 at 10:09 AM, Keith Packard wrote: > Kristian H?gsberg writes: > >> It just the two older create context functions (which fall back to >> calling driCreateContextAtribs) and allocateBuffer and releaseBuffer. >> The two buffer functions are __DRIbuffer specific of course, but we

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-06 Thread Keith Packard
Kristian H?gsberg writes: > It just the two older create context functions (which fall back to > calling driCreateContextAtribs) and allocateBuffer and releaseBuffer. > The two buffer functions are __DRIbuffer specific of course, but we > can implement them in terms of __DRIimage in dri_util.c no

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-06 Thread Kristian Høgsberg
On Wed, Nov 6, 2013 at 6:55 AM, Keith Packard wrote: > Kristian H?gsberg writes: > >> Having written the GBM and Wayland suport for this, it's pretty clear >> that we just want to use __DRIdri2Extension instead of duplicating >> these functions. Support for the __DRIimage based getBuffers is a >

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-06 Thread Keith Packard
Kristian H?gsberg writes: > Having written the GBM and Wayland suport for this, it's pretty clear > that we just want to use __DRIdri2Extension instead of duplicating > these functions. Support for the __DRIimage based getBuffers is a > small incremental patch to src/egl/drivers/dri2: That woul

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-05 Thread Kristian Høgsberg
On Mon, Nov 04, 2013 at 06:23:27PM -0800, Keith Packard wrote: > These provide an interface between the driver and the loader to allocate > color buffers through the DRIimage extension interface rather than through a > loader-specific extension (as is used by DRI2, for instance). > > The driver us

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-05 Thread Kristian Høgsberg
On Tue, Nov 5, 2013 at 4:59 PM, Keith Packard wrote: > Kristian H?gsberg writes: > > >> We can drop width and height now and just get it from either of the >> returned images. Format is a function of the __DRIconfig and doesn't >> change, so we could make that something you can query from the co

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-05 Thread Keith Packard
Kristian H?gsberg writes: > We can drop width and height now and just get it from either of the > returned images. Format is a function of the __DRIconfig and doesn't > change, so we could make that something you can query from the config > in the interest of further reducing the number of argu

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-05 Thread Keith Packard
Eric Anholt writes: > Most of my review was going to be whining about yet another (broken) > copy of dri2CreateNewScreen2. Sounds like you've fixed that. Yup, figured that out all on my own after I re-read the code -- the only difference was that I need to look for the DRIimageLoader hooks, whi

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-05 Thread Kristian Høgsberg
On Mon, Nov 04, 2013 at 06:23:27PM -0800, Keith Packard wrote: > These provide an interface between the driver and the loader to allocate > color buffers through the DRIimage extension interface rather than through a > loader-specific extension (as is used by DRI2, for instance). > > The driver us

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-05 Thread Eric Anholt
Keith Packard writes: > These provide an interface between the driver and the loader to allocate > color buffers through the DRIimage extension interface rather than through a > loader-specific extension (as is used by DRI2, for instance). > > The driver uses the loader 'getBuffers' interface to

[PATCH 7/8] dri: add __DRIimageLoaderExtension and __DRIimageDriverExtension

2013-11-04 Thread Keith Packard
These provide an interface between the driver and the loader to allocate color buffers through the DRIimage extension interface rather than through a loader-specific extension (as is used by DRI2, for instance). The driver uses the loader 'getBuffers' interface to allocate color buffers. The load