[PATCH 6/7] drm/crtc: add sanity checks to create_dumb()

2014-01-21 Thread Ville Syrjälä
On Tue, Jan 21, 2014 at 12:17:35PM +0100, David Herrmann wrote: > Hi > > On Tue, Jan 21, 2014 at 10:49 AM, Daniel Vetter wrote: > > On Mon, Jan 20, 2014 at 08:26:28PM +0100, David Herrmann wrote: > >> Lets make sure some basic expressions are always true: > >> bpp != NULL > >> width != NULL >

[PATCH 6/7] drm/crtc: add sanity checks to create_dumb()

2014-01-21 Thread David Herrmann
Hi On Tue, Jan 21, 2014 at 12:42 PM, Ville Syrj?l? wrote: > On Tue, Jan 21, 2014 at 12:17:35PM +0100, David Herrmann wrote: >> Hi >> >> On Tue, Jan 21, 2014 at 10:49 AM, Daniel Vetter wrote: >> > On Mon, Jan 20, 2014 at 08:26:28PM +0100, David Herrmann wrote: >> >> Lets make sure some basic expr

[PATCH 6/7] drm/crtc: add sanity checks to create_dumb()

2014-01-21 Thread David Herrmann
Hi On Tue, Jan 21, 2014 at 10:49 AM, Daniel Vetter wrote: > On Mon, Jan 20, 2014 at 08:26:28PM +0100, David Herrmann wrote: >> Lets make sure some basic expressions are always true: >> bpp != NULL >> width != NULL >> height != NULL >> stride = bpp * width < 2^32 >> size = stride * heigh

[PATCH 6/7] drm/crtc: add sanity checks to create_dumb()

2014-01-21 Thread Chris Wilson
On Tue, Jan 21, 2014 at 12:52:36PM +0100, David Herrmann wrote: > Hi > > On Tue, Jan 21, 2014 at 12:42 PM, Ville Syrj?l? > wrote: > > On Tue, Jan 21, 2014 at 12:17:35PM +0100, David Herrmann wrote: > >> Hi > >> > >> On Tue, Jan 21, 2014 at 10:49 AM, Daniel Vetter wrote: > >> > On Mon, Jan 20, 20

[PATCH 6/7] drm/crtc: add sanity checks to create_dumb()

2014-01-21 Thread Daniel Vetter
On Mon, Jan 20, 2014 at 08:26:28PM +0100, David Herrmann wrote: > Lets make sure some basic expressions are always true: > bpp != NULL > width != NULL > height != NULL > stride = bpp * width < 2^32 > size = stride * height < 2^32 > PAGE_ALIGN(size) < 2^32 > > At least the udl driver do

[PATCH 6/7] drm/crtc: add sanity checks to create_dumb()

2014-01-20 Thread David Herrmann
Lets make sure some basic expressions are always true: bpp != NULL width != NULL height != NULL stride = bpp * width < 2^32 size = stride * height < 2^32 PAGE_ALIGN(size) < 2^32 At least the udl driver doesn't check for multiplication-overflows, so lets just make sure it will never hap