Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

2024-05-30 Thread Aradhya Bhatia
Hi Maxime, On 28/05/24 17:13, Maxime Ripard wrote: > On Fri, May 24, 2024 at 04:38:13PM GMT, Aradhya Bhatia wrote: >> Hi Maxime, >> >> On 21/05/24 18:45, Maxime Ripard wrote: >>> Hi, >>> >>> On Thu, May 16, 2024 at 03:10:15PM GMT, Aradhya Bhatia wrote: >> /** >> * @pre_e

Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

2024-05-28 Thread Maxime Ripard
On Fri, May 24, 2024 at 04:38:13PM GMT, Aradhya Bhatia wrote: > Hi Maxime, > > On 21/05/24 18:45, Maxime Ripard wrote: > > Hi, > > > > On Thu, May 16, 2024 at 03:10:15PM GMT, Aradhya Bhatia wrote: > /** > * @pre_enable: > * > @@ -285,6 +319,26 @@ s

Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

2024-05-24 Thread Aradhya Bhatia
Hi Maxime, On 21/05/24 18:45, Maxime Ripard wrote: > Hi, > > On Thu, May 16, 2024 at 03:10:15PM GMT, Aradhya Bhatia wrote: /** * @pre_enable: * @@ -285,6 +319,26 @@ struct drm_bridge_funcs { */ void (*enable)(struct drm_bridge *bridge);

Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

2024-05-21 Thread Maxime Ripard
Hi, On Thu, May 16, 2024 at 03:10:15PM GMT, Aradhya Bhatia wrote: > >>/** > >> * @pre_enable: > >> * > >> @@ -285,6 +319,26 @@ struct drm_bridge_funcs { > >> */ > >>void (*enable)(struct drm_bridge *bridge); > >> > >> + /** > >> + * @atomic_early_enable: > >> + * > >> +

Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

2024-05-16 Thread Aradhya Bhatia
Hi Maxime, Thank you for reviewing the patches! On 16/05/24 13:52, Maxime Ripard wrote: > On Sat, May 11, 2024 at 09:00:50PM +0530, Aradhya Bhatia wrote: >> diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h >> index 4baca0d9107b..40f93230abb2 100644 >> --- a/include/drm/drm_bridge.

Re: [PATCH 6/7] drm/bridge: Introduce early_enable and late disable

2024-05-16 Thread Maxime Ripard
On Sat, May 11, 2024 at 09:00:50PM +0530, Aradhya Bhatia wrote: > diff --git a/include/drm/drm_bridge.h b/include/drm/drm_bridge.h > index 4baca0d9107b..40f93230abb2 100644 > --- a/include/drm/drm_bridge.h > +++ b/include/drm/drm_bridge.h > @@ -206,6 +206,20 @@ struct drm_bridge_funcs { >*/

[PATCH 6/7] drm/bridge: Introduce early_enable and late disable

2024-05-11 Thread Aradhya Bhatia
With the existing pre_enable and enable function hooks, the order of enable of display elements looks as follows, crtc_enable -> bridge[n]_pre_enable -> ... -> bridge[1]_pre_enable -> encoder_enable -> bridge[1]_enable -> ... -> bridge[n]_enable and vice versa for the disable. Some bridges need