Re: [PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2025-01-09 Thread Dmitry Baryshkov
On Wed, Jan 08, 2025 at 09:22:56PM -0800, Abhinav Kumar wrote: > > > On 1/8/2025 8:26 PM, Dmitry Baryshkov wrote: > > On Wed, Jan 08, 2025 at 08:11:27PM -0800, Abhinav Kumar wrote: > > > > > > > > > On 1/8/2025 6:27 PM, Abhinav Kumar wrote: > > > > > > > > > > > > On 12/21/2024 9:00 PM, Dmitr

Re: [PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2025-01-08 Thread Abhinav Kumar
On 1/8/2025 8:26 PM, Dmitry Baryshkov wrote: On Wed, Jan 08, 2025 at 08:11:27PM -0800, Abhinav Kumar wrote: On 1/8/2025 6:27 PM, Abhinav Kumar wrote: On 12/21/2024 9:00 PM, Dmitry Baryshkov wrote: The MSM driver uses drm_atomic_helper_check() which mandates that none of the atomic_check

Re: [PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2025-01-08 Thread Dmitry Baryshkov
On Wed, Jan 08, 2025 at 06:27:13PM -0800, Abhinav Kumar wrote: > > > On 12/21/2024 9:00 PM, Dmitry Baryshkov wrote: > > The MSM driver uses drm_atomic_helper_check() which mandates that none > > of the atomic_check() callbacks toggles crtc_state->mode_changed. > > Perform corresponding check befo

Re: [PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2025-01-08 Thread Dmitry Baryshkov
On Wed, Jan 08, 2025 at 08:11:27PM -0800, Abhinav Kumar wrote: > > > On 1/8/2025 6:27 PM, Abhinav Kumar wrote: > > > > > > On 12/21/2024 9:00 PM, Dmitry Baryshkov wrote: > > > The MSM driver uses drm_atomic_helper_check() which mandates that none > > > of the atomic_check() callbacks toggles cr

Re: [PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2025-01-08 Thread Abhinav Kumar
On 1/8/2025 6:27 PM, Abhinav Kumar wrote: On 12/21/2024 9:00 PM, Dmitry Baryshkov wrote: The MSM driver uses drm_atomic_helper_check() which mandates that none of the atomic_check() callbacks toggles crtc_state->mode_changed. Perform corresponding check before calling the drm_atomic_helper_

Re: [PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2025-01-08 Thread Abhinav Kumar
On 12/21/2024 9:00 PM, Dmitry Baryshkov wrote: The MSM driver uses drm_atomic_helper_check() which mandates that none of the atomic_check() callbacks toggles crtc_state->mode_changed. Perform corresponding check before calling the drm_atomic_helper_check() function. Fixes: 8b45a26f2ba9 ("drm/

Re: [PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2025-01-08 Thread Dmitry Baryshkov
On Wed, 8 Jan 2025 at 19:55, Simona Vetter wrote: > > On Sun, Dec 22, 2024 at 07:00:46AM +0200, Dmitry Baryshkov wrote: > > The MSM driver uses drm_atomic_helper_check() which mandates that none > > of the atomic_check() callbacks toggles crtc_state->mode_changed. > > Perform corresponding check b

Re: [PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2025-01-08 Thread Simona Vetter
On Sun, Dec 22, 2024 at 07:00:46AM +0200, Dmitry Baryshkov wrote: > The MSM driver uses drm_atomic_helper_check() which mandates that none > of the atomic_check() callbacks toggles crtc_state->mode_changed. > Perform corresponding check before calling the drm_atomic_helper_check() > function. > >

[PATCH 6/6] drm/msm/dpu: don't set crtc_state->mode_changed from atomic_check()

2024-12-21 Thread Dmitry Baryshkov
The MSM driver uses drm_atomic_helper_check() which mandates that none of the atomic_check() callbacks toggles crtc_state->mode_changed. Perform corresponding check before calling the drm_atomic_helper_check() function. Fixes: 8b45a26f2ba9 ("drm/msm/dpu: reserve cdm blocks for writeback in case of