Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-08-03 Thread Ben Widawsky
On 17-08-03 10:08:51, Daniel Vetter wrote: On Wed, Aug 2, 2017 at 5:43 PM, Ben Widawsky wrote: On 17-08-02 12:14:15, Daniel Vetter wrote: On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote: On 17-07-31 10:29:55, Daniel Vetter wrote: > On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-08-03 Thread Daniel Vetter
On Wed, Aug 2, 2017 at 5:43 PM, Ben Widawsky wrote: > On 17-08-02 12:14:15, Daniel Vetter wrote: >> >> On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote: >>> >>> On 17-07-31 10:29:55, Daniel Vetter wrote: >>> > On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: >>> > > On 17-

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-08-02 Thread Ben Widawsky
On 17-08-02 12:14:15, Daniel Vetter wrote: On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote: On 17-07-31 10:29:55, Daniel Vetter wrote: > On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: > > On 17-07-29 13:53:10, Daniel Stone wrote: > > > Hi Ben, > > > > > > On 26 July 2

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-08-02 Thread Daniel Vetter
On Tue, Aug 01, 2017 at 09:14:50AM -0700, Ben Widawsky wrote: > On 17-07-31 10:29:55, Daniel Vetter wrote: > > On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: > > > On 17-07-29 13:53:10, Daniel Stone wrote: > > > > Hi Ben, > > > > > > > > On 26 July 2017 at 19:08, Ben Widawsky wrote:

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-08-01 Thread Ben Widawsky
On 17-07-31 10:29:55, Daniel Vetter wrote: On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: On 17-07-29 13:53:10, Daniel Stone wrote: > Hi Ben, > > On 26 July 2017 at 19:08, Ben Widawsky wrote: > > + } else if (INTEL_GEN(dev_priv) >= 9) { > > intel_primary_for

Re: [Intel-gfx] [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-07-31 Thread Daniel Vetter
On Sat, Jul 29, 2017 at 09:25:50AM -0700, Ben Widawsky wrote: > On 17-07-29 13:53:10, Daniel Stone wrote: > > Hi Ben, > > > > On 26 July 2017 at 19:08, Ben Widawsky wrote: > > > + } else if (INTEL_GEN(dev_priv) >= 9) { > > > intel_primary_formats = skl_primary_formats; > > >

Re: [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-07-29 Thread Ben Widawsky
On 17-07-29 13:53:10, Daniel Stone wrote: Hi Ben, On 26 July 2017 at 19:08, Ben Widawsky wrote: + } else if (INTEL_GEN(dev_priv) >= 9) { intel_primary_formats = skl_primary_formats; num_formats = ARRAY_SIZE(skl_primary_formats); - modifiers =

Re: [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-07-29 Thread Daniel Stone
Hi, On 26 July 2017 at 19:08, Ben Widawsky wrote: > +static const uint64_t skl_plane_format_modifiers_noccs[] = { > + I915_FORMAT_MOD_Yf_TILED, > + I915_FORMAT_MOD_Y_TILED, > + I915_FORMAT_MOD_X_TILED, > + DRM_FORMAT_MOD_LINEAR, > + DRM_FORMAT_MOD_INVALID > +}; > + >

Re: [PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-07-29 Thread Daniel Stone
Hi Ben, On 26 July 2017 at 19:08, Ben Widawsky wrote: > + } else if (INTEL_GEN(dev_priv) >= 9) { > intel_primary_formats = skl_primary_formats; > num_formats = ARRAY_SIZE(skl_primary_formats); > - modifiers = skl_format_modifiers; > +

[PATCH 6/6] drm/i915: Add support for CCS modifiers

2017-07-26 Thread Ben Widawsky
v2: Support sprite plane. Support pipe C/D limitation on GEN9. v3: Rename structure (Ville) Handle GLK (Ville) This requires rebase on the correct Ville patches Cc: Daniel Stone Cc: Kristian Høgsberg Signed-off-by: Ben Widawsky --- drivers/gpu/drm/i915/intel_display.c | 30 ++