Re: [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-25 Thread Boris Ostrovsky
On 02/23/2018 02:53 AM, Oleksandr Andrushchenko wrote: > On 02/23/2018 02:25 AM, Boris Ostrovsky wrote: >> On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: >>> static int __init xen_drv_init(void) >>> { >>> +/* At the moment we only support case with XEN_PAGE_SIZE == >>> PAGE_SIZE *

Re: [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-23 Thread Oleksandr Andrushchenko
On 02/23/2018 04:36 PM, Boris Ostrovsky wrote: On 02/23/2018 02:53 AM, Oleksandr Andrushchenko wrote: On 02/23/2018 02:25 AM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: static int __init xen_drv_init(void) { +/* At the moment we only support case

Re: [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-23 Thread Boris Ostrovsky
On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: > > static int __init xen_drv_init(void) > { > + /* At the moment we only support case with XEN_PAGE_SIZE == PAGE_SIZE */ > + BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE); Why BUILD_BUG_ON? This should simply not load if page sizes ar

Re: [PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-22 Thread Oleksandr Andrushchenko
On 02/23/2018 02:25 AM, Boris Ostrovsky wrote: On 02/21/2018 03:03 AM, Oleksandr Andrushchenko wrote: static int __init xen_drv_init(void) { + /* At the moment we only support case with XEN_PAGE_SIZE == PAGE_SIZE */ + BUILD_BUG_ON(XEN_PAGE_SIZE != PAGE_SIZE); Why BUILD_BUG_O

[PATCH 5/9] drm/xen-front: Implement handling of shared display buffers

2018-02-21 Thread Oleksandr Andrushchenko
From: Oleksandr Andrushchenko Implement shared buffer handling according to the para-virtualized display device protocol at xen/interface/io/displif.h: - handle page directories according to displif protocol: - allocate and share page directories - grant references to the required set o