Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-08-04 Thread Daniel Vetter
On Wed, Aug 4, 2021 at 10:00 AM Thomas Hellström wrote: > > Hi, > > On 7/22/21 11:59 AM, Matthew Auld wrote: > > On Thu, 22 Jul 2021 at 10:49, Matthew Auld > > wrote: > >> On Wed, 21 Jul 2021 at 21:11, Jason Ekstrand wrote: > >>> On Mon, Jul 19, 2021 at 8:35 AM Matthew Auld > >>> wrote: >

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-08-04 Thread Thomas Hellström
Hi, On 7/22/21 11:59 AM, Matthew Auld wrote: On Thu, 22 Jul 2021 at 10:49, Matthew Auld wrote: On Wed, 21 Jul 2021 at 21:11, Jason Ekstrand wrote: On Mon, Jul 19, 2021 at 8:35 AM Matthew Auld wrote: On Fri, 16 Jul 2021 at 20:49, Jason Ekstrand wrote: On Fri, Jul 16, 2021 at 1:45 PM Matth

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-22 Thread Matthew Auld
On Thu, 22 Jul 2021 at 10:49, Matthew Auld wrote: > > On Wed, 21 Jul 2021 at 21:11, Jason Ekstrand wrote: > > > > On Mon, Jul 19, 2021 at 8:35 AM Matthew Auld > > wrote: > > > > > > On Fri, 16 Jul 2021 at 20:49, Jason Ekstrand wrote: > > > > > > > > On Fri, Jul 16, 2021 at 1:45 PM Matthew Auld

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-22 Thread Matthew Auld
On Wed, 21 Jul 2021 at 21:11, Jason Ekstrand wrote: > > On Mon, Jul 19, 2021 at 8:35 AM Matthew Auld > wrote: > > > > On Fri, 16 Jul 2021 at 20:49, Jason Ekstrand wrote: > > > > > > On Fri, Jul 16, 2021 at 1:45 PM Matthew Auld > > > wrote: > > > > > > > > On Fri, 16 Jul 2021 at 18:39, Jason Eks

Re: [Intel-gfx] [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-21 Thread Daniel Vetter
On Wed, Jul 21, 2021 at 10:11 PM Jason Ekstrand wrote: > > On Mon, Jul 19, 2021 at 8:35 AM Matthew Auld > wrote: > > > > On Fri, 16 Jul 2021 at 20:49, Jason Ekstrand wrote: > > > > > > On Fri, Jul 16, 2021 at 1:45 PM Matthew Auld > > > wrote: > > > > > > > > On Fri, 16 Jul 2021 at 18:39, Jason

[PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-21 Thread Jason Ekstrand
Whenever we had a user object (n_placements > 0), we were ignoring obj->mm.region and always putting obj->placements[0] as the requested region. For LMEM+SMEM objects, this was causing them to get shoved into LMEM on every i915_ttm_get_pages() even when SMEM was requested by, say, i915_gem_object_

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-21 Thread Jason Ekstrand
On Mon, Jul 19, 2021 at 8:35 AM Matthew Auld wrote: > > On Fri, 16 Jul 2021 at 20:49, Jason Ekstrand wrote: > > > > On Fri, Jul 16, 2021 at 1:45 PM Matthew Auld > > wrote: > > > > > > On Fri, 16 Jul 2021 at 18:39, Jason Ekstrand wrote: > > > > > > > > On Fri, Jul 16, 2021 at 11:00 AM Matthew Au

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-19 Thread Matthew Auld
On Fri, 16 Jul 2021 at 20:49, Jason Ekstrand wrote: > > On Fri, Jul 16, 2021 at 1:45 PM Matthew Auld > wrote: > > > > On Fri, 16 Jul 2021 at 18:39, Jason Ekstrand wrote: > > > > > > On Fri, Jul 16, 2021 at 11:00 AM Matthew Auld > > > wrote: > > > > > > > > On Fri, 16 Jul 2021 at 16:52, Matthew

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-16 Thread Jason Ekstrand
On Fri, Jul 16, 2021 at 1:45 PM Matthew Auld wrote: > > On Fri, 16 Jul 2021 at 18:39, Jason Ekstrand wrote: > > > > On Fri, Jul 16, 2021 at 11:00 AM Matthew Auld > > wrote: > > > > > > On Fri, 16 Jul 2021 at 16:52, Matthew Auld > > > wrote: > > > > > > > > On Fri, 16 Jul 2021 at 15:10, Jason Ek

Re: [Intel-gfx] [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-16 Thread Matthew Auld
On Fri, 16 Jul 2021 at 15:14, Jason Ekstrand wrote: > > Whenever we had a user object (n_placements > 0), we were ignoring > obj->mm.region and always putting obj->placements[0] as the requested > region. For LMEM+SMEM objects, this was causing them to get shoved into > LMEM on every i915_ttm_get

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-16 Thread Matthew Auld
On Fri, 16 Jul 2021 at 18:39, Jason Ekstrand wrote: > > On Fri, Jul 16, 2021 at 11:00 AM Matthew Auld > wrote: > > > > On Fri, 16 Jul 2021 at 16:52, Matthew Auld > > wrote: > > > > > > On Fri, 16 Jul 2021 at 15:10, Jason Ekstrand wrote: > > > > > > > > On Fri, Jul 16, 2021 at 8:54 AM Matthew Au

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-16 Thread Jason Ekstrand
On Fri, Jul 16, 2021 at 11:00 AM Matthew Auld wrote: > > On Fri, 16 Jul 2021 at 16:52, Matthew Auld > wrote: > > > > On Fri, 16 Jul 2021 at 15:10, Jason Ekstrand wrote: > > > > > > On Fri, Jul 16, 2021 at 8:54 AM Matthew Auld > > > wrote: > > > > > > > > On Thu, 15 Jul 2021 at 23:39, Jason Ekst

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-16 Thread Matthew Auld
On Fri, 16 Jul 2021 at 16:52, Matthew Auld wrote: > > On Fri, 16 Jul 2021 at 15:10, Jason Ekstrand wrote: > > > > On Fri, Jul 16, 2021 at 8:54 AM Matthew Auld > > wrote: > > > > > > On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > > > > > > > Whenever we had a user object (n_placements >

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-16 Thread Matthew Auld
On Fri, 16 Jul 2021 at 15:10, Jason Ekstrand wrote: > > On Fri, Jul 16, 2021 at 8:54 AM Matthew Auld > wrote: > > > > On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > > > > > Whenever we had a user object (n_placements > 0), we were ignoring > > > obj->mm.region and always putting obj->pl

[PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-16 Thread Jason Ekstrand
Whenever we had a user object (n_placements > 0), we were ignoring obj->mm.region and always putting obj->placements[0] as the requested region. For LMEM+SMEM objects, this was causing them to get shoved into LMEM on every i915_ttm_get_pages() even when SMEM was requested by, say, i915_gem_object_

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-16 Thread Jason Ekstrand
On Fri, Jul 16, 2021 at 8:54 AM Matthew Auld wrote: > > On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > > > Whenever we had a user object (n_placements > 0), we were ignoring > > obj->mm.region and always putting obj->placements[0] as the requested > > region. For LMEM+SMEM objects, this

Re: [PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-16 Thread Matthew Auld
On Thu, 15 Jul 2021 at 23:39, Jason Ekstrand wrote: > > Whenever we had a user object (n_placements > 0), we were ignoring > obj->mm.region and always putting obj->placements[0] as the requested > region. For LMEM+SMEM objects, this was causing them to get shoved into > LMEM on every i915_ttm_get

[PATCH 5/7] drm/i915/gem/ttm: Respect the objection region in placement_from_obj

2021-07-15 Thread Jason Ekstrand
Whenever we had a user object (n_placements > 0), we were ignoring obj->mm.region and always putting obj->placements[0] as the requested region. For LMEM+SMEM objects, this was causing them to get shoved into LMEM on every i915_ttm_get_pages() even when SMEM was requested by, say, i915_gem_object_