Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

Hi Thomas, On Fri, Apr 28, 2023 at 1:20 PM Thomas Zimmermann wrote: > Am 26.04.23 um 17:21 schrieb Geert Uytterhoeven: > > On Wed, Apr 26, 2023 at 5:06 PM Thomas Zimmermann > > wrote: > >> Am 26.04.23 um 17:01 schrieb Geert Uytterhoeven: > >>> On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

Hi Am 26.04.23 um 17:21 schrieb Geert Uytterhoeven: Hi Thomas, On Wed, Apr 26, 2023 at 5:06 PM Thomas Zimmermann wrote: Am 26.04.23 um 17:01 schrieb Geert Uytterhoeven: On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: Move the existing CFB read and write code for I/O memory into th

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

Hi Thomas, On Wed, Apr 26, 2023 at 5:06 PM Thomas Zimmermann wrote: > Am 26.04.23 um 17:01 schrieb Geert Uytterhoeven: > > On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann > > wrote: > >> Move the existing CFB read and write code for I/O memory into > >> the new helpers fb_cfb_read() and fb_cf

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

Hi Am 26.04.23 um 17:01 schrieb Geert Uytterhoeven: Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: Move the existing CFB read and write code for I/O memory into the new helpers fb_cfb_read() and fb_cfb_write(). Make them the default fp_ops. No functional changes. Signed-

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

Hi Thomas, On Tue, Apr 25, 2023 at 4:28 PM Thomas Zimmermann wrote: > Move the existing CFB read and write code for I/O memory into > the new helpers fb_cfb_read() and fb_cfb_write(). Make them the > default fp_ops. No functional changes. > > Signed-off-by: Thomas Zimmermann > --- > drivers/vid

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

patch link: https://lore.kernel.org/r/20230425142846.730-6-tzimmermann%40suse.de patch subject: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions config: riscv-randconfig-s033-20230423 (https://download.01.org/0day-ci/archive/20230426/202304261317.qaewarcb-...@intel.com/config

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

m/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230425142846.730-6-tzimmermann%40suse.de patch subject: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions config: openrisc-randconfig-s052-20230423 (https://download.01.org/0day-ci/archive/20230426/20230426141

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

m/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230425142846.730-6-tzimmermann%40suse.de patch subject: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions config: nios2-randconfig-s031-20230423 (https://download.01.org/0day-ci/archive/20230426/20230426133

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

m/drm-misc drm-misc-next patch link: https://lore.kernel.org/r/20230425142846.730-6-tzimmermann%40suse.de patch subject: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions config: riscv-randconfig-s033-20230423 (https://download.01.org/0day-ci/archive/20230426/20230426131

Re: [PATCH 5/6] fbdev: Move CFB read and write code into helper functions

Thomas Zimmermann writes: > Move the existing CFB read and write code for I/O memory into > the new helpers fb_cfb_read() and fb_cfb_write(). Make them the > default fp_ops. No functional changes. > It would be nice to get an explanation here about why moving these make sense. I guess you are do

[PATCH 5/6] fbdev: Move CFB read and write code into helper functions

Move the existing CFB read and write code for I/O memory into the new helpers fb_cfb_read() and fb_cfb_write(). Make them the default fp_ops. No functional changes. Signed-off-by: Thomas Zimmermann --- drivers/video/fbdev/core/Makefile | 2 +- drivers/video/fbdev/core/fb_cfb_fops.c | 126