Re: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers

2020-01-29 Thread Chris Wilson
Quoting Daniel Vetter (2020-01-29 08:24:10) > @@ -378,9 +409,10 @@ int drm_open(struct inode *inode, struct file *filp) > if (IS_ERR(minor)) > return PTR_ERR(minor); > > - mutex_unlock(&drm_global_mutex); > - > dev = minor->dev; > + if (drm_dev_needs_gl

Re: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers

2020-01-29 Thread Daniel Vetter
On Wed, Jan 29, 2020 at 05:47:33PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > In the nit-pick department today - sorry. > > Subject: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers > I did not understand this subject... - what is "Nerv"? It's a

Re: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers

2020-01-29 Thread Sam Ravnborg
Hi Daniel. In the nit-pick department today - sorry. Subject: [PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers I did not understand this subject... - what is "Nerv"? Sam On Wed, Jan 29, 2020 at 09:24:10AM +0100, Daniel Vetter wrote: > This catches the majori

[PATCH 5/5] drm: Nerv drm_global_mutex BKL for good drivers

2020-01-29 Thread Daniel Vetter
This catches the majority of drivers (unfortunately not if we take users into account, because all the big drivers have at least a lastclose hook). With the prep patches out of the way all drm state is fully protected and either prevents or can deal with the races from dropping the BKL around open