[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-02-11 Thread Daniel Vetter
On Sat, Feb 2, 2013 at 12:05 AM, Laurent Pinchart wrote: >> Back to the original topic: should it not work to queue a page flip and >> immediately exit(0) after that to test the cleanup code? I suppose if >> that can be tested on all drivers we should have pretty good coverage. > > Maybe we need s

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-02-11 Thread Daniel Vetter
On Sat, Feb 2, 2013 at 12:05 AM, Laurent Pinchart wrote: >> Back to the original topic: should it not work to queue a page flip and >> immediately exit(0) after that to test the cleanup code? I suppose if >> that can be tested on all drivers we should have pretty good coverage. > > Maybe we need s

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-02-02 Thread Laurent Pinchart
Hi Thierry, On Wednesday 16 January 2013 19:56:06 Thierry Reding wrote: > On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding wrote: > > > drm_events_release() should be enough to clean up the events, but I > > > suspect the reason wh

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-02-02 Thread Laurent Pinchart
On Wednesday 16 January 2013 13:36:17 Daniel Vetter wrote: > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding wrote: > > drm_events_release() should be enough to clean up the events, but I > > suspect the reason why Laurent put that code in was that the drm_crtc > > private data still has a referen

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-02-01 Thread Laurent Pinchart
Hi Thierry, On Wednesday 16 January 2013 19:56:06 Thierry Reding wrote: > On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding wrote: > > > drm_events_release() should be enough to clean up the events, but I > > > suspect the reason wh

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-02-01 Thread Laurent Pinchart
On Wednesday 16 January 2013 13:36:17 Daniel Vetter wrote: > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding wrote: > > drm_events_release() should be enough to clean up the events, but I > > suspect the reason why Laurent put that code in was that the drm_crtc > > private data still has a referen

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-30 Thread Thierry Reding
On Wed, Jan 30, 2013 at 12:14:36PM +0100, Thierry Reding wrote: > On Wed, Jan 30, 2013 at 11:42:40AM +0200, Ville Syrj?l? wrote: > > On Wed, Jan 30, 2013 at 10:32:47AM +0100, Thierry Reding wrote: > > > On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > > > > On Wed, Jan 16, 2013 at 1

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-30 Thread Thierry Reding
On Wed, Jan 30, 2013 at 11:42:40AM +0200, Ville Syrj?l? wrote: > On Wed, Jan 30, 2013 at 10:32:47AM +0100, Thierry Reding wrote: > > On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > > > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > > > wrote: > > > > drm_events_release() shoul

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-30 Thread Ville Syrjälä
On Wed, Jan 30, 2013 at 10:32:47AM +0100, Thierry Reding wrote: > On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > > wrote: > > > drm_events_release() should be enough to clean up the events, but I > > > suspect the reason why La

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-30 Thread Thierry Reding
On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > wrote: > > drm_events_release() should be enough to clean up the events, but I > > suspect the reason why Laurent put that code in was that the drm_crtc > > private data still has a

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-30 Thread Thierry Reding
On Wed, Jan 30, 2013 at 12:14:36PM +0100, Thierry Reding wrote: > On Wed, Jan 30, 2013 at 11:42:40AM +0200, Ville Syrjälä wrote: > > On Wed, Jan 30, 2013 at 10:32:47AM +0100, Thierry Reding wrote: > > > On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > > > > On Wed, Jan 16, 2013 at 1

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-30 Thread Thierry Reding
On Wed, Jan 30, 2013 at 11:42:40AM +0200, Ville Syrjälä wrote: > On Wed, Jan 30, 2013 at 10:32:47AM +0100, Thierry Reding wrote: > > On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > > > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > > > wrote: > > > > drm_events_release() shoul

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-30 Thread Ville Syrjälä
On Wed, Jan 30, 2013 at 10:32:47AM +0100, Thierry Reding wrote: > On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > > wrote: > > > drm_events_release() should be enough to clean up the events, but I > > > suspect the reason why La

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-30 Thread Thierry Reding
On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > wrote: > > drm_events_release() should be enough to clean up the events, but I > > suspect the reason why Laurent put that code in was that the drm_crtc > > private data still has a

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Thierry Reding
On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > wrote: > > drm_events_release() should be enough to clean up the events, but I > > suspect the reason why Laurent put that code in was that the drm_crtc > > private data still has a

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Daniel Vetter
On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding wrote: > drm_events_release() should be enough to clean up the events, but I > suspect the reason why Laurent put that code in was that the drm_crtc > private data still has a reference to the event and needs to clear it. > Otherwise the next page f

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Thierry Reding
On Wed, Jan 16, 2013 at 10:43:15AM +0100, Daniel Vetter wrote: > On Tue, Jan 15, 2013 at 9:17 PM, Thierry Reding > wrote: > > On Tue, Jan 15, 2013 at 06:53:19PM +0100, Daniel Vetter wrote: > >> On Mon, Jan 14, 2013 at 4:55 PM, Thierry Reding > >> wrote: > >> > +static void tegra_drm_preclose(stru

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Thierry Reding
On Wed, Jan 16, 2013 at 01:36:17PM +0100, Daniel Vetter wrote: > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > wrote: > > drm_events_release() should be enough to clean up the events, but I > > suspect the reason why Laurent put that code in was that the drm_crtc > > private data still has a

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Daniel Vetter
On Tue, Jan 15, 2013 at 9:17 PM, Thierry Reding wrote: > On Tue, Jan 15, 2013 at 06:53:19PM +0100, Daniel Vetter wrote: >> On Mon, Jan 14, 2013 at 4:55 PM, Thierry Reding >> wrote: >> > +static void tegra_drm_preclose(struct drm_device *drm, struct drm_file >> > *file) >> > +{ >> > + struc

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Rob Clark
On Wed, Jan 16, 2013 at 6:36 AM, Daniel Vetter wrote: > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > wrote: >> drm_events_release() should be enough to clean up the events, but I >> suspect the reason why Laurent put that code in was that the drm_crtc >> private data still has a reference t

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Rob Clark
On Wed, Jan 16, 2013 at 6:36 AM, Daniel Vetter wrote: > On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding > wrote: >> drm_events_release() should be enough to clean up the events, but I >> suspect the reason why Laurent put that code in was that the drm_crtc >> private data still has a reference t

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Daniel Vetter
On Wed, Jan 16, 2013 at 11:01 AM, Thierry Reding wrote: > drm_events_release() should be enough to clean up the events, but I > suspect the reason why Laurent put that code in was that the drm_crtc > private data still has a reference to the event and needs to clear it. > Otherwise the next page f

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Thierry Reding
On Wed, Jan 16, 2013 at 10:43:15AM +0100, Daniel Vetter wrote: > On Tue, Jan 15, 2013 at 9:17 PM, Thierry Reding > wrote: > > On Tue, Jan 15, 2013 at 06:53:19PM +0100, Daniel Vetter wrote: > >> On Mon, Jan 14, 2013 at 4:55 PM, Thierry Reding > >> wrote: > >> > +static void tegra_drm_preclose(stru

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-16 Thread Daniel Vetter
On Tue, Jan 15, 2013 at 9:17 PM, Thierry Reding wrote: > On Tue, Jan 15, 2013 at 06:53:19PM +0100, Daniel Vetter wrote: >> On Mon, Jan 14, 2013 at 4:55 PM, Thierry Reding >> wrote: >> > +static void tegra_drm_preclose(struct drm_device *drm, struct drm_file >> > *file) >> > +{ >> > + struc

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-15 Thread Thierry Reding
On Tue, Jan 15, 2013 at 06:53:19PM +0100, Daniel Vetter wrote: > On Mon, Jan 14, 2013 at 4:55 PM, Thierry Reding > wrote: > > +static void tegra_drm_preclose(struct drm_device *drm, struct drm_file > > *file) > > +{ > > + struct drm_crtc *crtc; > > + > > + list_for_each_entry(crtc, &d

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-15 Thread Daniel Vetter
On Mon, Jan 14, 2013 at 4:55 PM, Thierry Reding wrote: > +static void tegra_drm_preclose(struct drm_device *drm, struct drm_file *file) > +{ > + struct drm_crtc *crtc; > + > + list_for_each_entry(crtc, &drm->mode_config.crtc_list, head) > + tegra_dc_cancel_page_flip(crtc,

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-15 Thread Thierry Reding
On Tue, Jan 15, 2013 at 06:53:19PM +0100, Daniel Vetter wrote: > On Mon, Jan 14, 2013 at 4:55 PM, Thierry Reding > wrote: > > +static void tegra_drm_preclose(struct drm_device *drm, struct drm_file > > *file) > > +{ > > + struct drm_crtc *crtc; > > + > > + list_for_each_entry(crtc, &d

Re: [PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-15 Thread Daniel Vetter
On Mon, Jan 14, 2013 at 4:55 PM, Thierry Reding wrote: > +static void tegra_drm_preclose(struct drm_device *drm, struct drm_file *file) > +{ > + struct drm_crtc *crtc; > + > + list_for_each_entry(crtc, &drm->mode_config.crtc_list, head) > + tegra_dc_cancel_page_flip(crtc,

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-14 Thread Thierry Reding
All the necessary support bits like .mode_set_base() and VBLANK are now available, so page-flipping case easily be implemented on top. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 72 + drivers/gpu/drm/tegra/drm.c | 9 ++ driver

[PATCH 5/5] drm/tegra: Implement page-flipping support

2013-01-14 Thread Thierry Reding
All the necessary support bits like .mode_set_base() and VBLANK are now available, so page-flipping case easily be implemented on top. Signed-off-by: Thierry Reding --- drivers/gpu/drm/tegra/dc.c | 72 + drivers/gpu/drm/tegra/drm.c | 9 ++ driver