[PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-17 Thread Rob Clark
On Tue, Oct 8, 2013 at 11:34 AM, Jean-Francois Moine wrote: > On Tue, 8 Oct 2013 10:49:39 +0100 > Russell King - ARM Linux wrote: > >> On Tue, Oct 08, 2013 at 11:19:13AM +0200, Jean-Francois Moine wrote: >> > The Cubox is an open platform, and I use it just like a desktop PC. >> > When its requir

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-09 Thread Russell King - ARM Linux
On Tue, Oct 08, 2013 at 11:19:13AM +0200, Jean-Francois Moine wrote: > The Cubox is an open platform, and I use it just like a desktop PC. > When its required drivers will be in the mainline, I will do the same > as I do with PCs: I will not recompile a specific kernel each time > there are kernel

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-08 Thread Jean-Francois Moine
On Tue, 8 Oct 2013 10:49:39 +0100 Russell King - ARM Linux wrote: > On Tue, Oct 08, 2013 at 11:19:13AM +0200, Jean-Francois Moine wrote: > > The Cubox is an open platform, and I use it just like a desktop PC. > > When its required drivers will be in the mainline, I will do the same > > as I do wi

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-08 Thread Rob Clark
On Tue, Oct 8, 2013 at 5:19 AM, Jean-Francois Moine wrote: > On Mon, 7 Oct 2013 10:59:39 -0400 > Rob Clark wrote: > >> Jean-François, just as an aside, I really don't think code that can be >> shared, like tda998x, should encode a DT requirement.. there are >> plenty of platforms that don't use D

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-08 Thread Jean-Francois Moine
On Mon, 7 Oct 2013 10:59:39 -0400 Rob Clark wrote: > Jean-François, just as an aside, I really don't think code that can be > shared, like tda998x, should encode a DT requirement.. there are > plenty of platforms that don't use DT (arm isn't everything, and last > I heard aarch64 was going to be

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-08 Thread Mark Brown
On Mon, Oct 07, 2013 at 06:08:12PM +0200, Sebastian Hesselbarth wrote: > True, I didn't mention TDM modes squeezing multiple channels into one > L/R frame. Neither Dove nor TDA998x support this, but thanks for the > clarification. Depending on how the DMA and so on is done you can sometimes still

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Sebastian Hesselbarth
On 10/07/2013 05:53 PM, Mark Brown wrote: On Mon, Oct 07, 2013 at 01:29:30PM +0200, Sebastian Hesselbarth wrote: I2S _can_ support more than two channels, but only if you wire up more DATA lines. Those are not available on Dove, so its I2S is limited to two channel audio. A lot of devices imp

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Mark Brown
On Mon, Oct 07, 2013 at 01:29:30PM +0200, Sebastian Hesselbarth wrote: > I2S _can_ support more than two channels, but only if you wire up more > DATA lines. Those are not available on Dove, so its I2S is limited to > two channel audio. A lot of devices implement extra channels with TDM rather th

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Russell King - ARM Linux
On Mon, Oct 07, 2013 at 02:03:27PM +0200, Jean-Francois Moine wrote: > On Mon, 7 Oct 2013 12:09:02 +0100 > Russell King - ARM Linux wrote: > > > > Here is a small story about i2s/spdif: once, I set the tda998x to use > > > the spdif input, and at this time, I was using the dummy codec. > > > This

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Sebastian Hesselbarth
On 10/07/2013 01:09 PM, Russell King - ARM Linux wrote: On Mon, Oct 07, 2013 at 12:48:20PM +0200, Jean-Francois Moine wrote: On Mon, 7 Oct 2013 10:44:04 +0100 Rabeeh did the most he could to have a working Cubox. He used bad written drivers and he had not the time to think about how the drivers

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Russell King - ARM Linux
On Mon, Oct 07, 2013 at 12:48:20PM +0200, Jean-Francois Moine wrote: > On Mon, 7 Oct 2013 10:44:04 +0100 > Russell King - ARM Linux wrote: > > > On Mon, Oct 07, 2013 at 11:18:07AM +0200, Jean-Francois Moine wrote: > [snip] > > > It seems we are going backwards: as the Armada based boards wi

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Russell King - ARM Linux
On Mon, Oct 07, 2013 at 11:18:07AM +0200, Jean-Francois Moine wrote: > On Sun, 06 Oct 2013 23:11:56 +0100 > Russell King wrote: > > > Signed-off-by: Russell King > > --- > > drivers/gpu/drm/armada/Kconfig |9 +++ > > drivers/gpu/drm/armada/armada_drv.c | 42 > > +

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Rob Clark
On Mon, Oct 7, 2013 at 7:09 AM, Russell King - ARM Linux wrote: > On Mon, Oct 07, 2013 at 12:48:20PM +0200, Jean-Francois Moine wrote: >> On Mon, 7 Oct 2013 10:44:04 +0100 >> Russell King - ARM Linux wrote: >> >> > On Mon, Oct 07, 2013 at 11:18:07AM +0200, Jean-Francois Moine wrote: >> [sni

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Jean-Francois Moine
On Mon, 7 Oct 2013 12:09:02 +0100 Russell King - ARM Linux wrote: > > Here is a small story about i2s/spdif: once, I set the tda998x to use > > the spdif input, and at this time, I was using the dummy codec. > > This codec accepts the format 32_LE, as does the audio device, but the > > output can

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Jean-Francois Moine
On Mon, 7 Oct 2013 10:44:04 +0100 Russell King - ARM Linux wrote: > On Mon, Oct 07, 2013 at 11:18:07AM +0200, Jean-Francois Moine wrote: [snip] > > It seems we are going backwards: as the Armada based boards will soon > > move to full DT (mvebu), you are making an exception for the Cubox,

Re: [PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Jean-Francois Moine
On Sun, 06 Oct 2013 23:11:56 +0100 Russell King wrote: > Signed-off-by: Russell King > --- > drivers/gpu/drm/armada/Kconfig |9 +++ > drivers/gpu/drm/armada/armada_drv.c | 42 > +++ > 2 files changed, 51 insertions(+), 0 deletions(-) > > diff --g

[PATCH 5/5] DRM: Armada: add support for drm tda19988 driver

2013-10-07 Thread Russell King
Signed-off-by: Russell King --- drivers/gpu/drm/armada/Kconfig |9 +++ drivers/gpu/drm/armada/armada_drv.c | 42 +++ 2 files changed, 51 insertions(+), 0 deletions(-) diff --git a/drivers/gpu/drm/armada/Kconfig b/drivers/gpu/drm/armada/Kconfig index