Re: [PATCH 4/9] drm: meson: vpp: use proper macros instead of magic constants

2019-08-08 Thread Neil Armstrong
On 25/06/2019 01:15, Kevin Hilman wrote: > Julien Masson writes: > >> This patch add new macros which are used to set the following >> registers: >> - VPP_OSD_SCALE_COEF_IDX >> - VPP_DOLBY_CTRL >> - VPP_OFIFO_SIZE >> - VPP_HOLD_LINES >> - VPP_SC_MISC >> - VPP_VADJ_CTRL >> >> Signed-off-by: Julien

[PATCH 4/9] drm: meson: vpp: use proper macros instead of magic constants

2019-06-25 Thread Julien Masson
This patch add new macros which are used to set the following registers: - VPP_OSD_SCALE_COEF_IDX - VPP_DOLBY_CTRL - VPP_OFIFO_SIZE - VPP_HOLD_LINES - VPP_SC_MISC - VPP_VADJ_CTRL Signed-off-by: Julien Masson --- drivers/gpu/drm/meson/meson_registers.h | 8 drivers/gpu/drm/meson/meson_v

Re: [PATCH 4/9] drm: meson: vpp: use proper macros instead of magic constants

2019-06-24 Thread Kevin Hilman
Julien Masson writes: > This patch add new macros which are used to set the following > registers: > - VPP_OSD_SCALE_COEF_IDX > - VPP_DOLBY_CTRL > - VPP_OFIFO_SIZE > - VPP_HOLD_LINES > - VPP_SC_MISC > - VPP_VADJ_CTRL > > Signed-off-by: Julien Masson [...] > @@ -97,20 +97,22 @@ void meson_vpp_i