Re: [PATCH 4/9] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-24 Thread Thierry Reding
On Tue, Mar 23, 2021 at 10:05:23PM +0300, Dmitry Osipenko wrote: > 23.03.2021 21:24, Thierry Reding пишет: > > On Tue, Mar 23, 2021 at 08:57:42PM +0300, Dmitry Osipenko wrote: > >> 23.03.2021 18:54, Thierry Reding пишет: > >>> @@ -920,15 +934,42 @@ static void tegra_cursor_atomic_update(struct > >

Re: [PATCH 4/9] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-23 Thread Dmitry Osipenko
23.03.2021 21:24, Thierry Reding пишет: > On Tue, Mar 23, 2021 at 08:57:42PM +0300, Dmitry Osipenko wrote: >> 23.03.2021 18:54, Thierry Reding пишет: >>> @@ -920,15 +934,42 @@ static void tegra_cursor_atomic_update(struct >>> drm_plane *plane, >>> value = tegra_dc_readl(dc, DC_DISP_BLEND_CURSO

Re: [PATCH 4/9] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-23 Thread Thierry Reding
On Tue, Mar 23, 2021 at 08:57:42PM +0300, Dmitry Osipenko wrote: > 23.03.2021 18:54, Thierry Reding пишет: > > @@ -920,15 +934,42 @@ static void tegra_cursor_atomic_update(struct > > drm_plane *plane, > > value = tegra_dc_readl(dc, DC_DISP_BLEND_CURSOR_CONTROL); > > value &= ~CURSOR_DST_BL

Re: [PATCH 4/9] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-23 Thread Dmitry Osipenko
23.03.2021 18:54, Thierry Reding пишет: > @@ -920,15 +934,42 @@ static void tegra_cursor_atomic_update(struct drm_plane > *plane, > value = tegra_dc_readl(dc, DC_DISP_BLEND_CURSOR_CONTROL); > value &= ~CURSOR_DST_BLEND_MASK; > value &= ~CURSOR_SRC_BLEND_MASK; > - value |= CUR

[PATCH 4/9] drm/tegra: dc: Implement hardware cursor on Tegra186 and later

2021-03-23 Thread Thierry Reding
From: Thierry Reding The hardware cursor on Tegra186 differs slightly from the implementation on older SoC generations. In particular the new implementation relies on software for clipping the cursor against the screen. Fortunately, atomic KMS already computes clipped coordinates for (cursor) pla