Re: [PATCH 4/9] drm/meson: dw-hdmi: fix incorrect comment in suspend

2024-08-19 Thread Neil Armstrong
On 30/07/2024 14:50, Jerome Brunet wrote: Comment in suspend says TOP is put in suspend, but the register poke following is actually de-asserting the reset, like in init. It is doing the opposite of what the comment says. Align the comment with what the code is doing for now and add a FIXME not

Re: [PATCH 4/9] drm/meson: dw-hdmi: fix incorrect comment in suspend

2024-08-06 Thread Martin Blumenstingl
On Tue, Jul 30, 2024 at 2:50 PM Jerome Brunet wrote: > > Comment in suspend says TOP is put in suspend, but the register > poke following is actually de-asserting the reset, like in init. > > It is doing the opposite of what the comment says. > > Align the comment with what the code is doing for n

[PATCH 4/9] drm/meson: dw-hdmi: fix incorrect comment in suspend

2024-07-30 Thread Jerome Brunet
Comment in suspend says TOP is put in suspend, but the register poke following is actually de-asserting the reset, like in init. It is doing the opposite of what the comment says. Align the comment with what the code is doing for now and add a FIXME note to sort this out later Signed-off-by: Jer