Re: [PATCH 4/8] drm/i915/xehp: CCS should use RCS setup functions

2021-09-08 Thread Tvrtko Ursulin
On 08/09/2021 11:13, Tvrtko Ursulin wrote: On 07/09/2021 18:19, Matt Roper wrote: The compute engine handles the same commands the render engine can (except 3D pipeline), so it makes sense that CCS is more similar to RCS than non-render engines. The CCS context state (lrc) is also similar to

Re: [PATCH 4/8] drm/i915/xehp: CCS should use RCS setup functions

2021-09-08 Thread Tvrtko Ursulin
On 07/09/2021 18:19, Matt Roper wrote: The compute engine handles the same commands the render engine can (except 3D pipeline), so it makes sense that CCS is more similar to RCS than non-render engines. The CCS context state (lrc) is also similar to the render one, so reuse it. Note that the c

[PATCH 4/8] drm/i915/xehp: CCS should use RCS setup functions

2021-09-07 Thread Matt Roper
The compute engine handles the same commands the render engine can (except 3D pipeline), so it makes sense that CCS is more similar to RCS than non-render engines. The CCS context state (lrc) is also similar to the render one, so reuse it. Note that the compute engine has its own CTX_R_PWR_CLK_STA