Re: [PATCH 4/8] accel/qaic: delete qaic_bo.handle

2025-06-06 Thread Jeff Hugo
On 5/28/2025 3:13 AM, Simona Vetter wrote: Handles are per-file, not global, so this makes no sense. Plus it's set only after calling drm_gem_handle_create(), and drivers are not allowed to further intialize a bo after that function has published it already. It is also entirely unused, which hel

Re: [PATCH 4/8] accel/qaic: delete qaic_bo.handle

2025-06-03 Thread Jeff Hugo
On 6/2/2025 8:43 AM, Simona Vetter wrote: On Wed, May 28, 2025 at 09:15:22AM -0600, Jeff Hugo wrote: On 5/28/2025 3:13 AM, Simona Vetter wrote: Handles are per-file, not global, so this makes no sense. Plus it's set only after calling drm_gem_handle_create(), and drivers are not allowed to furt

Re: [PATCH 4/8] accel/qaic: delete qaic_bo.handle

2025-06-02 Thread Simona Vetter
On Wed, May 28, 2025 at 09:15:22AM -0600, Jeff Hugo wrote: > On 5/28/2025 3:13 AM, Simona Vetter wrote: > > Handles are per-file, not global, so this makes no sense. Plus it's > > set only after calling drm_gem_handle_create(), and drivers are not > > allowed to further intialize a bo after that fu

Re: [PATCH 4/8] accel/qaic: delete qaic_bo.handle

2025-05-28 Thread Jeff Hugo
On 5/28/2025 3:13 AM, Simona Vetter wrote: Handles are per-file, not global, so this makes no sense. Plus it's set only after calling drm_gem_handle_create(), and drivers are not allowed to further intialize a bo after that function has published it already. intialize -> initialize It is also

[PATCH 4/8] accel/qaic: delete qaic_bo.handle

2025-05-28 Thread Simona Vetter
Handles are per-file, not global, so this makes no sense. Plus it's set only after calling drm_gem_handle_create(), and drivers are not allowed to further intialize a bo after that function has published it already. It is also entirely unused, which helps enormously with removing it :-) Since we'