Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-09-22 Thread Tomi Valkeinen
On 21/09/2020 14:49, Pekka Paalanen wrote: > would it not be simplest if KMS UAPI specification defined the abstract > color pipeline with all the blocks that may be exposed with > driver-agnostic UAPI, and then just say that if a block is not present, > it behaves as pass-through, a no-op? > > E

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-09-22 Thread Daniel Stone
Hi, On Tue, 22 Sep 2020 at 08:44, Tomi Valkeinen wrote: > On 21/09/2020 14:49, Pekka Paalanen wrote: > > would it not be simplest if KMS UAPI specification defined the abstract > > color pipeline with all the blocks that may be exposed with > > driver-agnostic UAPI, and then just say that if a bl

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-09-22 Thread Pekka Paalanen
On Tue, 22 Sep 2020 10:44:38 +0300 Tomi Valkeinen wrote: > On 21/09/2020 14:49, Pekka Paalanen wrote: > > > would it not be simplest if KMS UAPI specification defined the abstract > > color pipeline with all the blocks that may be exposed with > > driver-agnostic UAPI, and then just say that if

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-09-21 Thread Tomi Valkeinen
Hi, On 04/09/2019 23:20, Ilia Mirkin wrote: >> Implement CTM color management property for OMAP CRTC using DSS >> overlay manager's Color Phase Rotation matrix. The CPR matrix does not >> exactly match the CTM property documentation. On DSS the CPR matrix is >> applied after gamma

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2020-09-21 Thread Pekka Paalanen
On Mon, 21 Sep 2020 14:08:48 +0300 Tomi Valkeinen wrote: > Hi, > > On 04/09/2019 23:20, Ilia Mirkin wrote: > > >> Implement CTM color management property for OMAP CRTC using DSS > >> overlay manager's Color Phase Rotation matrix. The CPR matrix does not > >> exactly match the CTM pr

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-05 Thread Jyri Sarha
On 05/09/2019 13:05, Laurent Pinchart wrote: > Hi Jyri, > > On Thu, Sep 05, 2019 at 01:00:51PM +0300, Jyri Sarha wrote: >> On 05/09/2019 00:52, Laurent Pinchart wrote: static void omap_crtc_write_crtc_properties(struct drm_crtc *crtc) { struct omap_drm_private *

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-05 Thread Laurent Pinchart
Hi Jyri, On Thu, Sep 05, 2019 at 01:00:51PM +0300, Jyri Sarha wrote: > On 05/09/2019 00:52, Laurent Pinchart wrote: > >> static void omap_crtc_write_crtc_properties(struct drm_crtc *crtc) > >> { > >>struct omap_drm_private *priv = crtc->dev->dev_private; > >> @@ -402,7 +4

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-05 Thread Jyri Sarha
On 05/09/2019 00:52, Laurent Pinchart wrote: >> static void omap_crtc_write_crtc_properties(struct drm_crtc *crtc) >> { >> struct omap_drm_private *priv = crtc->dev->dev_private; >> @@ -402,7 +428,16 @@ static void omap_crtc_write_crtc_properties(struct >> drm_crtc *

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-04 Thread Laurent Pinchart
Hi Jyri, On Wed, Sep 04, 2019 at 11:08:20PM +0300, Jyri Sarha wrote: > On 04/09/2019 14:11, Laurent Pinchart wrote: > > On Wed, Sep 04, 2019 at 10:17:00AM +0300, Jyri Sarha wrote: > >> On 03/09/2019 18:24, Laurent Pinchart wrote: > >>> On Mon, Sep 02, 2019 at 03:53:56PM +0300, Tomi Valkeinen wrote

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-04 Thread Ilia Mirkin
On Wed, Sep 4, 2019 at 4:08 PM Jyri Sarha wrote: > > On 04/09/2019 14:11, Laurent Pinchart wrote: > > Hi Jyri, > > > > On Wed, Sep 04, 2019 at 10:17:00AM +0300, Jyri Sarha wrote: > >> On 03/09/2019 18:24, Laurent Pinchart wrote: > >>> On Mon, Sep 02, 2019 at 03:53:56PM +0300, Tomi Valkeinen wrote:

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-04 Thread Jyri Sarha
On 04/09/2019 14:11, Laurent Pinchart wrote: > Hi Jyri, > > On Wed, Sep 04, 2019 at 10:17:00AM +0300, Jyri Sarha wrote: >> On 03/09/2019 18:24, Laurent Pinchart wrote: >>> On Mon, Sep 02, 2019 at 03:53:56PM +0300, Tomi Valkeinen wrote: From: Jyri Sarha Implement CTM color managemen

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-04 Thread Laurent Pinchart
Hi Jyri, On Wed, Sep 04, 2019 at 10:17:00AM +0300, Jyri Sarha wrote: > On 03/09/2019 18:24, Laurent Pinchart wrote: > > On Mon, Sep 02, 2019 at 03:53:56PM +0300, Tomi Valkeinen wrote: > >> From: Jyri Sarha > >> > >> Implement CTM color management property for OMAP CRTC using DSS > >> overlay mana

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-04 Thread Jyri Sarha
On 03/09/2019 18:24, Laurent Pinchart wrote: > Hi Tomi, > > Thank you for the patch. > > On Mon, Sep 02, 2019 at 03:53:56PM +0300, Tomi Valkeinen wrote: >> From: Jyri Sarha >> >> Implement CTM color management property for OMAP CRTC using DSS >> overlay manager's Color Phase Rotation matrix. The

Re: [PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-03 Thread Laurent Pinchart
Hi Tomi, Thank you for the patch. On Mon, Sep 02, 2019 at 03:53:56PM +0300, Tomi Valkeinen wrote: > From: Jyri Sarha > > Implement CTM color management property for OMAP CRTC using DSS > overlay manager's Color Phase Rotation matrix. The CPR matrix does not > exactly match the CTM property docu

[PATCH 4/7] drm/omap: Implement CTM property for CRTC using OVL managers CPR matrix

2019-09-02 Thread Tomi Valkeinen
From: Jyri Sarha Implement CTM color management property for OMAP CRTC using DSS overlay manager's Color Phase Rotation matrix. The CPR matrix does not exactly match the CTM property documentation. On DSS the CPR matrix is applied after gamma table look up. However, it seems stupid to add a custo