Re: [PATCH 4/5] drm: Push drm_global_mutex locking in drm_open

2020-02-10 Thread Chris Wilson
Quoting Daniel Vetter (2020-02-04 15:01:45) > We want to only take the BKL on crap drivers, but to know whether > we have a crap driver we first need to look it up. Split this shuffle > out from the main BKL-disabling patch, for more clarity. Historical > aside: When the kernel-wide BKL was removed

[PATCH 4/5] drm: Push drm_global_mutex locking in drm_open

2020-02-04 Thread Daniel Vetter
We want to only take the BKL on crap drivers, but to know whether we have a crap driver we first need to look it up. Split this shuffle out from the main BKL-disabling patch, for more clarity. Historical aside: When the kernel-wide BKL was removed, it was replaced by drm_global_mutex within the sco

Re: [PATCH 4/5] drm: Push drm_global_mutex locking in drm_open

2020-01-29 Thread Daniel Vetter
On Wed, Jan 29, 2020 at 05:45:45PM +0100, Sam Ravnborg wrote: > Hi Daniel. > > On Wed, Jan 29, 2020 at 09:24:09AM +0100, Daniel Vetter wrote: > > We want to only take the BKL on crap drivers, but to know whether > The BKL was killed long time ago.. > In other words I was confused until I realized

Re: [PATCH 4/5] drm: Push drm_global_mutex locking in drm_open

2020-01-29 Thread Sam Ravnborg
Hi Daniel. On Wed, Jan 29, 2020 at 09:24:09AM +0100, Daniel Vetter wrote: > We want to only take the BKL on crap drivers, but to know whether The BKL was killed long time ago.. In other words I was confused until I realized that - BKL - drm_global_mutex BKL - drm_global_mutex Was all the same. At

[PATCH 4/5] drm: Push drm_global_mutex locking in drm_open

2020-01-29 Thread Daniel Vetter
We want to only take the BKL on crap drivers, but to know whether we have a crap driver we first need to look it up. Split this shuffle out from the main BKL-disabling patch, for more clarity. Since the minors are refcounted drm_minor_acquire is purely internal and this does not have a driver visi