Re: [PATCH 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2019-11-30 Thread Sam Ravnborg
Hi Jyri > I am not so sure if the DSS go-bit functionality (hw support to commit > changes to display during next vertical blank) so widely used concept > that it would make sense to make drm wide helpers to handle it. The question was the other way around. I was just wondering if there is some o

Re: [PATCH 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2019-11-27 Thread Jyri Sarha
Hi Sam, And thank you for the prompt review comments! On 26/11/2019 23:26, Sam Ravnborg wrote: > Hi Jyri. > > Took a quick look - looks like a very nice driver. > Some drive by comments below. > > I was left with the impression that there is a lot of code to support > vblank - and I wonder if th

Re: [PATCH 4/5] drm/tidss: New driver for TI Keystone platform Display SubSystem

2019-11-26 Thread Sam Ravnborg
Hi Jyri. Took a quick look - looks like a very nice driver. Some drive by comments below. I was left with the impression that there is a lot of code to support vblank - and I wonder if there is some general code that can help you here that you have missed. Sam On Tue, Nov 26, 2019 at 1