Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-05 Thread Shawn Guo
On Tue, Apr 04, 2017 at 01:46:48PM -0400, Sean Paul wrote: > > +static int zx_vga_register(struct drm_device *drm, struct zx_vga *vga) > > +{ > > + struct drm_encoder *encoder = &vga->encoder; > > + struct drm_connector *connector = &vga->connector; > > + > > + encoder->possible_crtcs = VOU_C

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-04 Thread Daniel Vetter
On Wed, Apr 05, 2017 at 02:08:52PM +0800, Shawn Guo wrote: > On Tue, Apr 04, 2017 at 01:32:39PM -0400, Sean Paul wrote: > > On Tue, Apr 04, 2017 at 09:47:38PM +0800, Shawn Guo wrote: > > > On Mon, Apr 03, 2017 at 11:23:51AM +0200, Daniel Vetter wrote: > > > > > +static int zx_vga_ddc_register(struc

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-04 Thread Shawn Guo
On Tue, Apr 04, 2017 at 01:32:39PM -0400, Sean Paul wrote: > On Tue, Apr 04, 2017 at 09:47:38PM +0800, Shawn Guo wrote: > > On Mon, Apr 03, 2017 at 11:23:51AM +0200, Daniel Vetter wrote: > > > > +static int zx_vga_ddc_register(struct zx_vga *vga) > > > > +{ > > > > + struct device *dev = vga-

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-04 Thread Sean Paul
On Tue, Mar 21, 2017 at 08:15:56PM +0800, Shawn Guo wrote: > From: Shawn Guo > > It adds VGA driver support, which needs to configure corresponding VOU > interface in RGB_888 format, and thus the following changes are needed > on zx_vou. > > - Rename the CSC block of Graphic Layer a bit to make

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-04 Thread Sean Paul
On Tue, Apr 04, 2017 at 09:47:38PM +0800, Shawn Guo wrote: > On Mon, Apr 03, 2017 at 11:23:51AM +0200, Daniel Vetter wrote: > > > +static int zx_vga_ddc_register(struct zx_vga *vga) > > > +{ > > > + struct device *dev = vga->dev; > > > + struct i2c_adapter *adap; > > > + struct zx_vga_i2c *ddc; > >

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-04 Thread Shawn Guo
On Mon, Apr 03, 2017 at 11:23:51AM +0200, Daniel Vetter wrote: > > +static int zx_vga_ddc_register(struct zx_vga *vga) > > +{ > > + struct device *dev = vga->dev; > > + struct i2c_adapter *adap; > > + struct zx_vga_i2c *ddc; > > + int ret; > > + > > + ddc = devm_kzalloc(dev, sizeof(*ddc),

Re: [PATCH 4/4] drm: zte: add VGA driver support

2017-04-03 Thread Daniel Vetter
On Tue, Mar 21, 2017 at 08:15:56PM +0800, Shawn Guo wrote: > From: Shawn Guo > > It adds VGA driver support, which needs to configure corresponding VOU > interface in RGB_888 format, and thus the following changes are needed > on zx_vou. > > - Rename the CSC block of Graphic Layer a bit to make

[PATCH 4/4] drm: zte: add VGA driver support

2017-03-21 Thread Shawn Guo
From: Shawn Guo It adds VGA driver support, which needs to configure corresponding VOU interface in RGB_888 format, and thus the following changes are needed on zx_vou. - Rename the CSC block of Graphic Layer a bit to make it more specific, and add CSC of Channel to support RGB output. - Bypas