Re: [PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support

2024-06-18 Thread Dmitry Baryshkov
On Tue, Jun 18, 2024 at 01:48:48PM GMT, Marc Gonzalez wrote: > On 18/06/2024 00:33, Dmitry Baryshkov wrote: > > > On Mon, Jun 17, 2024 at 06:03:02PM GMT, Marc Gonzalez wrote: > > > >> + if (sbridge->vcc) { > >> + ret = regulator_enable(sbridge->vcc); > >> + msleep(100); > > >

Re: [PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support

2024-06-18 Thread Marc Gonzalez
On 18/06/2024 00:33, Dmitry Baryshkov wrote: > On Mon, Jun 17, 2024 at 06:03:02PM GMT, Marc Gonzalez wrote: > >> +if (sbridge->vcc) { >> +ret = regulator_enable(sbridge->vcc); >> +msleep(100); > > At least this should be documented or explained in the commit message.

Re: [PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support

2024-06-17 Thread Dmitry Baryshkov
On Mon, Jun 17, 2024 at 06:03:02PM GMT, Marc Gonzalez wrote: > The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting > DVI 1.0 and HDMI 1.4b and 2.0b output signals. > > Signed-off-by: Marc Gonzalez > --- > drivers/gpu/drm/bridge/simple-bridge.c | 64 > +

[PATCH 4/4] drm: bridge: simple-bridge: add tdp158 support

2024-06-17 Thread Marc Gonzalez
The TI TDP158 is an AC-Coupled HDMI signal to TMDS Redriver supporting DVI 1.0 and HDMI 1.4b and 2.0b output signals. Signed-off-by: Marc Gonzalez --- drivers/gpu/drm/bridge/simple-bridge.c | 64 -- 1 file changed, 61 insertions(+), 3 deletions(-) diff --git a/dr