Re: [PATCH 4/4] drm/sun4i: backend: add missing of_node_puts

2019-01-16 Thread Maxime Ripard
On Sun, Jan 13, 2019 at 09:47:44AM +0100, Julia Lawall wrote: > The device node iterators perform an of_node_get on each > iteration, so a jump out of the loop requires an of_node_put. > > Remote and port also have augmented reference counts, so drop them > on each iteration and at the end of the

[PATCH 4/4] drm/sun4i: backend: add missing of_node_puts

2019-01-13 Thread Julia Lawall
The device node iterators perform an of_node_get on each iteration, so a jump out of the loop requires an of_node_put. Remote and port also have augmented reference counts, so drop them on each iteration and at the end of the function, respectively. Remote is only used for the address it contains,