Re: [Spice-devel] [PATCH 4/4] drm/qxl: add drm_driver.release callback.

2019-12-20 Thread Gerd Hoffmann
On Fri, Dec 20, 2019 at 07:09:20AM -0500, Frediano Ziglio wrote: > > > > Move final cleanups to qxl_drm_release() callback. > > Can you explain in the commit why this is better or preferable? It gets called when the drm device refcount goes down to zero. It's needed for a proper cleanup in the c

Re: [Spice-devel] [PATCH 4/4] drm/qxl: add drm_driver.release callback.

2019-12-20 Thread Frediano Ziglio
> > Move final cleanups to qxl_drm_release() callback. Can you explain in the commit why this is better or preferable? > Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). I suppose this is to replace the former manual cleanup calls, which were moved to qxl_drm_release, I think this cou

[PATCH 4/4] drm/qxl: add drm_driver.release callback.

2019-12-20 Thread Gerd Hoffmann
Move final cleanups to qxl_drm_release() callback. Add drm_atomic_helper_shutdown() call to qxl_pci_remove(). Reorder calls in qxl_device_fini(). Cleaning up gem & ttm might trigger qxl commands, so we should do that before releaseing command rings. Signed-off-by: Gerd Hoffmann --- drivers/gpu