Re: [PATCH 4/4] drm/panic: Add a qr_code panic screen

2024-07-04 Thread Jocelyn Falempe
On 04/07/2024 11:11, Alice Ryhl wrote: Jocelyn Falempe wrote: This patch adds a new panic screen, with a QR code and the kmsg data embedded. If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be compressed with zlib and encoded as a numerical segment, and appended to the url as

Re: [PATCH 4/4] drm/panic: Add a qr_code panic screen

2024-07-04 Thread Alice Ryhl
On Thu, Jul 4, 2024 at 11:28 AM Greg KH wrote: > > On Thu, Jul 04, 2024 at 09:11:09AM +, Alice Ryhl wrote: > > As long as the above requirements are satisfied, calling > > `drm_panic_qr_generate` should never cause memory unsafety, so this is > > an appropriate list of safety requirements. > >

Re: [PATCH 4/4] drm/panic: Add a qr_code panic screen

2024-07-04 Thread Greg KH
On Thu, Jul 04, 2024 at 09:11:09AM +, Alice Ryhl wrote: > As long as the above requirements are satisfied, calling > `drm_panic_qr_generate` should never cause memory unsafety, so this is > an appropriate list of safety requirements. > > (You also require that `data_len <= data_size`, but if t

Re: [PATCH 4/4] drm/panic: Add a qr_code panic screen

2024-07-04 Thread Alice Ryhl
Jocelyn Falempe wrote: > This patch adds a new panic screen, with a QR code and the kmsg data > embedded. > If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be > compressed with zlib and encoded as a numerical segment, and appended > to the url as a url parameter. This allows to sav

[PATCH 4/4] drm/panic: Add a qr_code panic screen

2024-07-03 Thread Jocelyn Falempe
This patch adds a new panic screen, with a QR code and the kmsg data embedded. If DRM_PANIC_SCREEN_QR_CODE_URL is set, then the kmsg data will be compressed with zlib and encoded as a numerical segment, and appended to the url as a url parameter. This allows to save space, and put about ~7500 bytes