Hi Sam,
On Tue, Jan 29, 2019 at 04:48:33PM +0100, Sam Ravnborg wrote:
> > > > + }
> > > > +
> > > > + drm_mode_set_name(mode);
> > > > +
> > > > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
> > > > + drm_mode_probed_add(connector, mode);
> > > > +
> > > >
Hi Maxime.
> > > + }
> > > +
> > > + drm_mode_set_name(mode);
> > > +
> > > + mode->type = DRM_MODE_TYPE_DRIVER | DRM_MODE_TYPE_PREFERRED;
> > > + drm_mode_probed_add(connector, mode);
> > > +
> > > + panel->connector->display_info.bpc = 8;
> > > + panel->connector->display_info.width_mm = 154;
>
Hi Sam,
Thanks for the review, I'll address the points left out.
On Sat, Jan 26, 2019 at 04:39:46PM +0100, Sam Ravnborg wrote:
> > + return ret;
> > + }
> > +
> > + /* Reset */
> > + msleep(20);
> > + gpiod_set_value(ctx->gpios.power, 1);
> > + msleep(20);
> > + gpiod_set_va
Hello, Sam!
Thank you for the comments.
>> +#include
> Please do not use drmP.h in new drivers. We are trying to get rid of it.
It can be replaced by these headers:
#include
#include
#include
> Use DRM_DEV_ERROR(...) to have consistent error message for the drm drivers.
> This is general fo
Hi Konstantin
> >> + ctx->gpios.updn = devm_gpiod_get(&dsi->dev, "updn", GPIOD_OUT_LOW);
> >> + if (IS_ERR(ctx->gpios.updn)) {
> >> + dev_err(&dsi->dev, "Couldn't get our updn GPIO\n");
> >> + return PTR_ERR(ctx->gpios.updn);
> >> + }
> > This gpio is never used, it is only read from DT
> The gpio
Hi Maxime / Konstantin.
Nice welstructured and small driver.
Please see a few comments below
Some of the comments in the following apply to a lot of
the existing panel drivers as well.
But lets see if we can get new drivers to be even better.
Sam
On Wed, Jan 23, 2019 at 04:54:24PM +010
From: Konstantin Sudakov
The Rondo RB070D30 panel is a MIPI-DSI panel based on a Fitipower EK79007
controller and a 1024x600 panel.
Signed-off-by: Konstantin Sudakov
Signed-off-by: Maxime Ripard
---
drivers/gpu/drm/panel/Kconfig| 9 +-
drivers/gpu/drm/panel/Makefile
