[PATCH 4/4] drm/msm: add OCMEM driver

2015-09-28 Thread Stephen Boyd
On 09/28, Rob Clark wrote: > On Mon, Sep 28, 2015 at 6:10 PM, Stephen Boyd wrote: > > On 09/28, Rob Clark wrote: > >> diff --git a/drivers/gpu/drm/msm/ocmem/ocmem.c > >> b/drivers/gpu/drm/msm/ocmem/ocmem.c > >> new file mode 100644 > >> index 000..d3cdd64 > >> --- /dev/null > >> +++ b/drivers

[PATCH 4/4] drm/msm: add OCMEM driver

2015-09-28 Thread Rob Clark
On Mon, Sep 28, 2015 at 6:10 PM, Stephen Boyd wrote: > On 09/28, Rob Clark wrote: >> @@ -322,10 +319,8 @@ static void a3xx_destroy(struct msm_gpu *gpu) >> >> adreno_gpu_cleanup(adreno_gpu); >> >> -#ifdef CONFIG_MSM_OCMEM >> if (a3xx_gpu->ocmem_base) > > Is this supposed to be ocmem_bas

[PATCH 4/4] drm/msm: add OCMEM driver

2015-09-28 Thread Stephen Boyd
On 09/28, Rob Clark wrote: > @@ -322,10 +319,8 @@ static void a3xx_destroy(struct msm_gpu *gpu) > > adreno_gpu_cleanup(adreno_gpu); > > -#ifdef CONFIG_MSM_OCMEM > if (a3xx_gpu->ocmem_base) Is this supposed to be ocmem_base or ocmem_hdl? Perhaps this check could be put inside the oc

[PATCH 4/4] drm/msm: add OCMEM driver

2015-09-28 Thread Rob Clark
For now, since the GPU is the only upstream consumer, just stuff this into drm/msm. Eventually if we have other consumers, we'll have to split this out and make the allocation less hard coded. But I'll punt on that until I better understand the non-gpu uses-cases (and whether the allocation *real