Re: [PATCH 4/4] drm/msm: Remove vma use tracking

2023-08-03 Thread Rob Clark
On Thu, Aug 3, 2023 at 1:38 AM Daniel Vetter wrote: > > On Wed, Aug 02, 2023 at 03:21:52PM -0700, Rob Clark wrote: > > From: Rob Clark > > > > This was not strictly necessary, as page unpinning (ie. shrinker) only > > cares about the resv. It did give us some extra sanity checking for > > usersp

Re: [PATCH 4/4] drm/msm: Remove vma use tracking

2023-08-03 Thread Daniel Vetter
On Wed, Aug 02, 2023 at 03:21:52PM -0700, Rob Clark wrote: > From: Rob Clark > > This was not strictly necessary, as page unpinning (ie. shrinker) only > cares about the resv. It did give us some extra sanity checking for > userspace controlled iova, and was useful to catch issues on kernel and

[PATCH 4/4] drm/msm: Remove vma use tracking

2023-08-02 Thread Rob Clark
From: Rob Clark This was not strictly necessary, as page unpinning (ie. shrinker) only cares about the resv. It did give us some extra sanity checking for userspace controlled iova, and was useful to catch issues on kernel and userspace side when enabling userspace iova. But if userspace screws