[PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj (v3)

2021-03-25 Thread Jason Ekstrand
This API is entirely unnecessary and I'd love to get rid of it. If userspace wants a single timeline across multiple contexts, they can either use implicit synchronization or a syncobj, both of which existed at the time this feature landed. The justification given at the time was that it would he

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-23 Thread Jason Ekstrand
On Tue, Mar 23, 2021 at 4:35 AM Tvrtko Ursulin wrote: > > > On 22/03/2021 16:10, Jason Ekstrand wrote: > > On Mon, Mar 22, 2021 at 7:28 AM Tvrtko Ursulin > > [snip] > > >>> diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > >>> b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c > >>> ind

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-23 Thread Tvrtko Ursulin
On 22/03/2021 16:10, Jason Ekstrand wrote: On Mon, Mar 22, 2021 at 7:28 AM Tvrtko Ursulin [snip] diff --git a/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c b/drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c index 96403130a373d..2c56796f6a71b 100644 --- a/drivers/gpu/drm/i915/gem/i915_gem_ex

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-22 Thread Jason Ekstrand
On Mon, Mar 22, 2021 at 11:59 AM Daniel Vetter wrote: > > On Fri, Mar 19, 2021 at 05:38:56PM -0500, Jason Ekstrand wrote: > > I'd love to delete the SINGLE_TIMELINE API because it leaks an > > implementation detail of contexts through to the API and is something > > that userspace can do itself, t

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-22 Thread Daniel Vetter
On Fri, Mar 19, 2021 at 05:38:56PM -0500, Jason Ekstrand wrote: > I'd love to delete the SINGLE_TIMELINE API because it leaks an > implementation detail of contexts through to the API and is something > that userspace can do itself, trivially. Unfortunately, it's used by > the media driver so we c

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-22 Thread Jason Ekstrand
On Mon, Mar 22, 2021 at 7:28 AM Tvrtko Ursulin wrote: > > > On 19/03/2021 22:38, Jason Ekstrand wrote: > > I'd love to delete the SINGLE_TIMELINE API because it leaks an > > implementation detail of contexts through to the API and is something > > that userspace can do itself, trivially. Unfortun

Re: [Intel-gfx] [PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-22 Thread Tvrtko Ursulin
On 19/03/2021 22:38, Jason Ekstrand wrote: I'd love to delete the SINGLE_TIMELINE API because it leaks an implementation detail of contexts through to the API and is something that userspace can do itself, trivially. Unfortunately, it's used by the media driver so we can't do that. We can, ho

[PATCH 4/4] drm/i915: Implement SINGLE_TIMELINE with a syncobj

2021-03-19 Thread Jason Ekstrand
I'd love to delete the SINGLE_TIMELINE API because it leaks an implementation detail of contexts through to the API and is something that userspace can do itself, trivially. Unfortunately, it's used by the media driver so we can't do that. We can, however, do the next-best thing which is to embed