Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures

2020-10-30 Thread Stephen Boyd
Quoting Doug Anderson (2020-10-29 09:22:55) > Hi, > > On Wed, Oct 28, 2020 at 6:12 PM Stephen Boyd wrote: > > > > We should be setting the drm_dp_aux_msg::reply field if a NACK or a > > SHORT reply happens. > > I don't think you update the "reply" field for SHORT, right? You just > return a dif

Re: [PATCH 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures

2020-10-29 Thread Doug Anderson
Hi, On Wed, Oct 28, 2020 at 6:12 PM Stephen Boyd wrote: > > We should be setting the drm_dp_aux_msg::reply field if a NACK or a > SHORT reply happens. I don't think you update the "reply" field for SHORT, right? You just return a different size? > Update the error bit handling logic in > ti_s

[PATCH 4/4] drm/bridge: ti-sn65dsi86: Update reply on aux failures

2020-10-29 Thread Stephen Boyd
We should be setting the drm_dp_aux_msg::reply field if a NACK or a SHORT reply happens. Update the error bit handling logic in ti_sn_aux_transfer() to handle these cases and notify upper layers that such errors have happened. This helps the retry logic understand that a timeout has happened, or to